Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 574133

Summary: Wrong Note text vertical alignment in collaborative environment
Product: [Modeling] Sirius Reporter: Laurent Redor <laurent.redor>
Component: DiagramAssignee: Laurent Redor <laurent.redor>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: pierre-charles.david
Version: 6.3.2   
Target Milestone: 6.5.1   
Hardware: PC   
OS: Windows 10   
See Also: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/181778
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=5121d26952bcfc3417c0b97575445fd69ba52aec
Whiteboard:
Bug Depends on:    
Bug Blocks: 574240, 574241    
Attachments:
Description Flags
Notes.zip none

Description Laurent Redor CLA 2021-06-10 09:47:52 EDT 
The fix done for bug 515044 was broken since Sirius 6.3.2 if Sirius is used in a collaborative environment. In this case, the label of new notes is centered vertically instead of being aligned at the top.

The goal of this issue is to:
* have a SiriusNoteViewFactory less strict (according to the type returned by "EcoreFactory.eINSTANCE.create(EcorePackage.Literals.ESTRING_TO_STRING_MAP_ENTRY)")
* add a migration participant to repair this kind of "broken" notes
Comment 1 Eclipse Genie CLA 2021-06-10 09:55:16 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/181778
Comment 2 Laurent Redor CLA 2021-06-11 03:53:13 EDT 
Created attachment 286566 [details]
Notes.zip

Steps to validate (using a data use case made in a collaborative environment)
* Import projet Notes from Notes.zip in a workspace (using Sirius 6.5.0)
* Open diagram "new ClassDiag"
* Expected (the current bug): The label Text2 is centered horizontally AND vertically.
* Import projet Notes from Notes.zip in a workspace (using Sirius 6.5.1)
* Open diagram "new ClassDiag"
* Expected: The label Text2 is always centered horizontally but aligned on the top.