Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 573893

Summary:	eclipsefdn/eca bot is failing a check on my Github account
Product:	Community	Reporter:	Tim Ellison <t.p.ellison>
Component:	My Account	Assignee:	phoenix.ui <phoenix.ui-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	chris.guindon, eric.poirier, martin.lowe, webdev, webmaster
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Tim Ellison

2021-06-01 12:10:29 EDT

My Eclipse account id is "tellison", and my Github username is "tellison".

I have listed my Github username in the Social Media Links Github Username field of my profile.

My Eclipse Contributor Agreement 3.0.0 is still valid, and a check using the ECA VALIDATION TOOL accessible from my account profile shows that I have a valid ECA.

However, the eclipsefdn/eca bot fails the check on a PR, by reporting that "Tim Ellison (tellison@****.noreply) is not covered by the necessary legal agreements in order to proceed."  Note the incorrect email subpart.

My email address actually ends with "@gmail.com" (not showing the full address here).

This was found via
https://accounts.eclipse.org/legal/eca/validation/67859

Comment 1 Tim Ellison

2021-06-01 12:14:46 EDT

FYI  I have committed to other repos successfully, so it may be specific to github.com/adoptium/temurin-build

Comment 2 Eclipse Webmaster

2021-06-01 14:16:39 EDT

Did you make this change via the Github web-UI or via cli tools?

-M.

Comment 3 Tim Ellison

2021-06-02 04:03:48 EDT

> Did you make this change via the Github web-UI or via cli tools?

Github web-UI

Comment 4 Christopher Guindon

2021-06-02 08:48:07 EDT

Eric, Martin,

Can you both take a look at this? I am not sure if the error is on the drupal site (accounts.eclipse.org) or the ECA validation service.

However, Tim has a valid ECA on file so this check should pass. He's using his github no.reply email for this PR:

https://api.github.com/repos/adoptium/temurin-build/pulls/2623/commits

We can trace back this GitHub no-reply email to an Eclipse account: https://api.eclipse.org/github/profile/tellison

Comment 5 Christopher Guindon

2021-06-02 09:13:51 EDT

Tim, feel free to tell the project that they can merge your PR while we work on a fix for this

They can validate your ECA status by clicking on your name here: https://accounts.eclipse.org/legal/eca/validation/67859

We recently made an update to the ECA validation service and I think we introduced a regression when a contribution is made with a @users.noreply.github.com email.

Comment 6 Tim Ellison

2021-06-03 05:10:09 EDT

Thanks, I will proceed to merge this contribution while the fix is being worked.

Comment 7 Martin Lowe

2021-06-03 08:45:10 EDT

Fix is up for review in the APIs GH repo: https://github.com/EclipseFdn/git-eca-rest-api/pull/60

From what I can tell Chris is dead on the money, this was a regression around no reply. I added the gh no reply and some tests so we can make sure we can catch this in the future!

Comment 8 Tim Ellison

2021-06-03 08:56:24 EDT

Let me know when you are ready, and I am happy to recheck my PRs with the patched bot.

Comment 9 Martin Lowe

2021-06-03 09:08:17 EDT

(In reply to Tim Ellison from comment #8)
> Let me know when you are ready, and I am happy to recheck my PRs with the
> patched bot.

Looks like the fix is live! We had a snappy review so I was able to push it up. From my tests it looks good, so let me know if it works for you as well!

Comment 10 Tim Ellison

2021-06-03 16:07:06 EDT

Check now works for me - thanks.

Comment 11 Martin Lowe

2021-06-04 08:57:07 EDT

(In reply to Tim Ellison from comment #10)
> Check now works for me - thanks.

Thanks Tim! Its always appreciated, thanks for submitting the bug and throwing in an extra test case for us to boot