Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 573634

Summary:

[DarkTheme] Default red color for Preference, Print Margin

Product:

[Eclipse Project] Platform

Reporter:

Vincenzo Caselli <vincenzo.caselli>

Component:

Assignee:

Lars Vogel <Lars.Vogel>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

Lars.Vogel, niraj.modi

Version:

4.19

Target Milestone:

4.21

Hardware:

OS:

Linux

See Also:

https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/181044
https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/181151
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=71cda5e217c1ba093d0f1f00eedac69f7eacc69d

Whiteboard:

Bug Depends on:

Bug Blocks:

574014

Attachments:

Description	Flags
Print Margin in Dark Theme	none
With suggested color	none

Description Vincenzo Caselli

2021-05-19 07:13:26 EDT

Created attachment 286419 [details]
Print Margin in Dark Theme

I am using Eclipse Dark Theme since a while now and I love it!
But (IMHO) it still has several non-optimal behaviors.
One of these is that the Print Margin is shown, into text editors, by default in red, which seems a bit confusing or at least a bit 'strong' (see attached image).
A possible solution (aside from agreeing with Bug 11259 - Print margin should be off by default) could be using the same color used by the Light Theme (light grey).
What do you think?

Comment 1 Lars Vogel

2021-05-19 10:47:03 EDT

Never noticed, as print margin is off by default.

+1 for changing it. Can you provide a Gerrit?

Comment 2 Vincenzo Caselli

2021-05-19 11:31:56 EDT

Hi Lars! 
what a pleasure to hear from you ;)
off by default? Strange: I installed a brand new Eclipse and found it enabled (and don't remember to have played with this preference in the past).

Anyway, I'm a little rusty about contributing via Gerrit. Can you point me out about the right repo, resources involved and any blueprint/guideline on Eclipse themes?
Thank you
Vincenzo

Comment 3 Lars Vogel

2021-05-19 11:44:47 EDT

Nice to hear from you too. 

You can follow my platform guide https://www.vogella.com/tutorials/EclipsePlatformDevelopment/article.html#exercise-clone-the-platform-ui-repository

Setup should be simple, let me know if you run into issues.

Comment 4 Vincenzo Caselli

2021-05-19 11:49:52 EDT

Ok, I'll follow your guide.

Any hint on why every brand new Eclipse comes with the Show Print Margin on while it should be off by default?

Comment 5 Lars Vogel

2021-05-26 08:58:21 EDT

Is 211,215,207 a good value?

Comment 6 Lars Vogel

2021-05-26 09:00:13 EDT

Created attachment 286458 [details]
With suggested color

Comment 7 Eclipse Genie

2021-05-26 09:02:04 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/181044

Comment 8 Lars Vogel

2021-05-28 04:47:35 EDT

Vincenzo, what do you think of my suggestion change?

Comment 9 Vincenzo Caselli

2021-05-28 16:21:01 EDT

I would have chosen an even lighter color (barely visible), but this is just my personal opinion.
I will try to make some alternative proposal via contribution.

Comment 10 Eclipse Genie

2021-05-28 17:17:12 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/181151

Comment 11 Niraj Modi

2021-06-03 01:33:29 EDT

Moving out of 4.20, please re-target as required.

Comment 12 Eclipse Genie

2021-06-07 07:02:09 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/181151 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=71cda5e217c1ba093d0f1f00eedac69f7eacc69d

Comment 13 Lars Vogel

2021-06-07 07:02:41 EDT

Thank you, Vincenzo. Looking forward to more improvements in the dark theme from you.