Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 572711

Summary: Use requestlayout in LazyStackRenderer
Product: [Eclipse Project] Platform Reporter: Rolf Theunissen <rolf.theunissen>
Component: UIAssignee: Rolf Theunissen <rolf.theunissen>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Lars.Vogel
Version: 4.19   
Target Milestone: 4.20 M2   
Hardware: PC   
OS: Windows 10   
See Also: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/179051
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=6168347458f5271abfb65f82d6d1d0a714fbdfa6
Whiteboard:
Bug Depends on:    
Bug Blocks: 571430    

Description Rolf Theunissen CLA 2021-04-08 13:38:38 EDT 
In LazyStackRenderer.showElementRecursive shared elements are re-parented to a new parent composite in a CTabFolder. A comment states that calling layout is too expensive, instead setSize is called.

To me it seems that calling requestlayout would be even less expensive, the effect is visible when switching perspectives. However, I don't know if there would be any potential regressions from this.
Comment 1 Lars Vogel CLA 2021-04-08 13:49:37 EDT 
Please upload a Gerrit. I can test on Linux.
Comment 2 Eclipse Genie CLA 2021-04-08 14:20:08 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/179051