Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 572519

Summary:	[Win32] Improve SWT Windows build.bat script
Product:	[Eclipse Project] Platform	Reporter:	Niraj Modi <niraj.modi>
Component:	SWT	Assignee:	Niraj Modi <niraj.modi>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	4.20
Target Milestone:	4.20 M1
Hardware:	PC
OS:	Windows 10
See Also:	https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/178694 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=d7d84ee476ba698a8a64a807c687ddbe03948968
Whiteboard:
Bug Depends on:
Bug Blocks:	572308

Description Niraj Modi

2021-04-01 05:28:52 EDT

Idea is to make SWT Windows build script bit more configurable on below lines:
- to handle different VS editions like 'Community', 'Enterprise', 'Professional'
- tweaking for VS version at on place like '2017' or newer '2019'

Comment 1 Eclipse Genie

2021-04-01 05:34:18 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/178694

Comment 2 Eclipse Genie

2021-04-01 06:08:38 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/178694 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=d7d84ee476ba698a8a64a807c687ddbe03948968

Comment 3 Niraj Modi

2021-04-01 06:42:54 EDT

(In reply to Eclipse Genie from comment #2)
> Gerrit change
> https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/178694 was
> merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=d7d84ee476ba698a8a64a807c687ddbe03948968

Resolving for M1.

Comment 4 Niraj Modi

2021-04-07 06:10:17 EDT

Verified on master using Eclipse Build id: I20210406-1800