Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 572215

Summary: Use JDT static inner class clean up in PDE
Product: [Eclipse Project] PDE Reporter: Lars Vogel <Lars.Vogel>
Component: UIAssignee: Lars Vogel <Lars.Vogel>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Lars.Vogel, Vikas.Chandra
Version: 4.14   
Target Milestone: 4.20 M3   
Hardware: PC   
OS: Linux   
See Also: https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/178252
https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=cf4edee0d6d8bcfdb9f06fdd60c736f5efadaeb6
https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/178970
https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/180215
https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/180216
https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/180217
https://git.eclipse.org/r/c/platform/eclipse.platform.runtime/+/180218
https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/180219
https://git.eclipse.org/r/c/platform/eclipse.platform.ua/+/180220
https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/180221
https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/180222
https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/180223
https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=efcc20cb8e5b252040c3ac7889c3dfe92b37bfc1
https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=11070384e058d28bc3187662ca270c693f00c658
https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=bb4d226c83f185b49b22d0d3d28ab946abc119d6
Whiteboard:
Bug Depends on:    
Bug Blocks: 571430    

Description Lars Vogel CLA 2021-03-23 05:27:53 EDT
This ticket uses and tests the "Use static inner class" cleanup feature:
 - It reviews the feature
 - It reduces the memory consumption as it avoids the pointer to the outer class

Example:

Before:

public class Outer {

public class InnerClass {
    int i;

    public boolean anotherMethod() {
        return true;
    }
}
}

After:

public class Outer {

public static class InnerClass {
    int i;

    public boolean anotherMethod() {
        return true;
    }
}
}
Comment 1 Eclipse Genie CLA 2021-03-23 05:29:38 EDT
New Gerrit change created: https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/178252
Comment 3 Eclipse Genie CLA 2021-04-07 10:59:01 EDT
New Gerrit change created: https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/178970
Comment 4 Eclipse Genie CLA 2021-05-05 05:24:10 EDT
New Gerrit change created: https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/180215
Comment 5 Eclipse Genie CLA 2021-05-05 05:24:11 EDT
New Gerrit change created: https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/180216
Comment 6 Eclipse Genie CLA 2021-05-05 05:24:22 EDT
New Gerrit change created: https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/180217
Comment 7 Eclipse Genie CLA 2021-05-05 05:25:03 EDT
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.runtime/+/180218
Comment 8 Eclipse Genie CLA 2021-05-05 05:26:14 EDT
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/180219
Comment 9 Eclipse Genie CLA 2021-05-05 05:26:26 EDT
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ua/+/180220
Comment 10 Eclipse Genie CLA 2021-05-05 05:27:37 EDT
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/180221
Comment 11 Eclipse Genie CLA 2021-05-05 05:28:18 EDT
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/180222
Comment 12 Eclipse Genie CLA 2021-05-05 05:28:59 EDT
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/180223
Comment 13 Lars Vogel CLA 2021-05-05 05:29:50 EDT
Sorry, not all Gerrits belong to this bug, just wrong copy and paste.
Comment 17 Vikas Chandra CLA 2021-05-20 03:28:19 EDT
Lars, can we resolve this one?
Comment 18 Lars Vogel CLA 2021-05-20 04:03:13 EDT
Yes, thanks for the reminder