Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 571724

Summary: JDT UI root planning bug for 4.20 release
Product: [Eclipse Project] JDT Reporter: Noopur Gupta <noopur_gupta>
Component: UIAssignee: Noopur Gupta <noopur_gupta>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: akurtakov, fabrice.tiercelin, kalyan_prasad, sarika.sinha
Version: 4.20   
Target Milestone: 4.20   
Hardware: All   
OS: All   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=572064
Whiteboard:

Description Noopur Gupta CLA 2021-03-05 06:42:54 EST
Please list the new features or big items (not the normal bug fixes) that you plan to work on during the 4.20 release.

See https://wiki.eclipse.org/JDT/Charter#JDT_Planning.C2.A0. 

The proposed items will be evaluated and approved based on the JDT Charter guidelines to be included in the plan for 4.20 release.
Comment 1 Noopur Gupta CLA 2021-03-05 06:53:54 EST
Proposing:

- Work on Java 17 support in JDT UI
- Work on JUnit 5.8 support (based on its release date): includes new features like declarative test suites
Comment 2 Noopur Gupta CLA 2021-03-05 09:35:17 EST
@All: Please list your items by March 12, 2021, to be included in the 4.20 plan.
Comment 3 Alexander Kurtakov CLA 2021-03-08 11:30:48 EST
(In reply to Noopur Gupta from comment #0)
> 
> The proposed items will be evaluated and approved based on the JDT Charter
> guidelines to be included in the plan for 4.20 release.

This troubles me a bit as it's unknown how much time one will be able to spend on during given time frame. Requiring approval (by whom?) to add something to the plan sounds duplicating the gerrit reviews as a committer reviews and approves it to get into master.
I am probably misinterpreting this but it was brought to my attention as a possibly unclear and/or questionable practice. So if this is just about things in the plan but features coming from others or developed due to changed resources capability/planning without being in/added to the plan shouldn't be ruled out as long as there are committers willing to take care of them.
Comment 4 Noopur Gupta CLA 2021-03-09 05:27:58 EST
(In reply to Alexander Kurtakov from comment #3)
> (In reply to Noopur Gupta from comment #0)
> > 
> > The proposed items will be evaluated and approved 
> Requiring approval (by whom?) to add
> something to the plan sounds duplicating the gerrit reviews as a committer
> reviews and approves it to get into master.
This is meant as "evaluated and discussed" among the contributors to provide any early feedback on the proposal and include them in the plan before the Gerrit part comes in.

> I am probably misinterpreting this but it was brought to my attention as a
> possibly unclear and/or questionable practice. So if this is just about
> things in the plan but features coming from others or developed due to
> changed resources capability/planning without being in/added to the plan
> shouldn't be ruled out as long as there are committers willing to take care
> of them.
This is the release planning that we have been doing all along which is being done via a root bug now to bring in the transparency. The idea is to plan ahead for big items that any contributor is thinking of adding to 4.20 and include them in the release plan. As always, the plan needs to evolve as we progress, taking into account the changed resources for example.
Comment 5 Alexander Kurtakov CLA 2021-03-09 05:32:39 EST
(In reply to Noopur Gupta from comment #4)
> (In reply to Alexander Kurtakov from comment #3)
> > (In reply to Noopur Gupta from comment #0)
> > > 
> > > The proposed items will be evaluated and approved 
> > Requiring approval (by whom?) to add
> > something to the plan sounds duplicating the gerrit reviews as a committer
> > reviews and approves it to get into master.
> This is meant as "evaluated and discussed" among the contributors to provide
> any early feedback on the proposal and include them in the plan before the
> Gerrit part comes in.
> 
> > I am probably misinterpreting this but it was brought to my attention as a
> > possibly unclear and/or questionable practice. So if this is just about
> > things in the plan but features coming from others or developed due to
> > changed resources capability/planning without being in/added to the plan
> > shouldn't be ruled out as long as there are committers willing to take care
> > of them.
> This is the release planning that we have been doing all along which is
> being done via a root bug now to bring in the transparency. The idea is to
> plan ahead for big items that any contributor is thinking of adding to 4.20
> and include them in the release plan. As always, the plan needs to evolve as
> we progress, taking into account the changed resources for example.

OK, I'm glad that I misunderstood it and adding new features later in the game would not be blocked.
Comment 6 Noopur Gupta CLA 2021-03-11 06:11:28 EST
(In reply to Noopur Gupta from comment #1)
> Proposing:
> 
> - Work on Java 17 support in JDT UI
> - Work on JUnit 5.8 support (based on its release date): includes new
> features like declarative test suites
Also:
- Bug 571009: Move junit.runtime BREE to JavaSE-1.8 or above
Comment 7 Noopur Gupta CLA 2021-03-24 02:20:49 EDT
Plan bugs have been created for Java 17 support and junit.runtime BREE update. Bug for JUnit 5.8 support to be created after it is released.
Comment 8 Fabrice Tiercelin CLA 2021-03-24 05:18:50 EDT
Here are some planned cleanups:
 - "valueOf() rather than instantiation" (Bug 572234)
 - "Map.entrySet() rather than Map.keySet() and value search"
 - "Int primitive rather than wrapper"
 - "Remove unchecked exceptions from throws clause"
Comment 9 Noopur Gupta CLA 2021-03-24 06:11:09 EDT
(In reply to Fabrice Tiercelin from comment #8)
> Here are some planned cleanups:
>  - "valueOf() rather than instantiation" (Bug 572234)
>  - "Map.entrySet() rather than Map.keySet() and value search"
>  - "Int primitive rather than wrapper"
>  - "Remove unchecked exceptions from throws clause"

Can you please create a top-level bug for new clean up options in 4.20 as discussed in bug 572234?
Comment 10 Fabrice Tiercelin CLA 2021-03-26 13:17:17 EDT
I create it here: Bug 572340
Comment 11 Noopur Gupta CLA 2021-03-30 05:05:03 EDT
(In reply to Fabrice Tiercelin from comment #10)
> I create it here: Bug 572340
Thanks!