Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 570606

Summary: [codemining] LineHeaderCodeMining allow constructor with explicit position
Product: [Eclipse Project] Platform Reporter: Christoph Laeubrich <laeubi>
Component: TextAssignee: Christoph Laeubrich <laeubi>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: mistria
Version: 4.14   
Target Milestone: 4.19 M2   
Hardware: All   
OS: All   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=540865
https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/175299
https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=c46da2478cf693c1d527c0fd00e0924169718062
Whiteboard:

Description Christoph Laeubrich CLA 2021-01-25 01:07:10 EST 
Currently the only way to have the codemining placed in a separate line is using LineHeaderCodeMining (code checks for this instance).

The LineHeaderCodeMining makes some assumptions about how to indent the mining (currently it indents as much as spaces are in the linde underneath), what not always is desirable (e.g. I want to place it so it is aligned with the line above + some extra indentation of 2 characters).

The obvious solution to this problem would be to have a constructor that accepts a position, the existing constructors can simply delegate.
Comment 1 Eclipse Genie CLA 2021-01-25 01:52:24 EST 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/175299
Comment 2 Mickael Istria CLA 2021-01-25 06:37:18 EST 
Thanks for this addition Christoph.