Bugzilla – Full Text Bug Listing
|
Description
Christopher Guindon
*** Bug 570532 has been marked as a duplicate of this bug. *** A bug was created yesterday by Shanda for this: https://bugs.eclipse.org/bugs/show_bug.cgi?id=570532 From the original bug: (In reply to Shanda Giacomoni from comment #0) > We would like to add functionality to newsroom.eclipse.org that would allow > the marketing team to set-up our own newsletter articles and configure the > newsletter landing page > (https://www.eclipse.org/community/eclipse_newsletter/). > > Proposed design: > https://xd.adobe.com/view/0f1bfb54-ae78-4492-96ef-350ba4fcdf02-5a48/ (In reply to Shanda Giacomoni from comment #1) > Note that the design is still being finalized. Sharing the current status to > get the webdev team started. Created attachment 285504 [details] Newsletter Redesign Mockup Please find the Adobe XD file of the Newsletter. https://xd.adobe.com/view/61741cf7-ec52-444c-b7f3-72200a53f27d-3427/ Created attachment 285505 [details]
Newsletter Redesign Mockup
Created attachment 285506 [details]
Newsletter subpage mockup- article page
Here You are Eric, I added the pngs. I will also add all the assets/images shortly. Created attachment 285511 [details]
Newsletter Banner image
Hello, I have upload the banner image. Please note all the other images used on the file are placeholders and will be changed based on content.
Today we had a meeting to look at the progress of the Newsletter implementation in Drupal. Here are action items for the Marketing team: - Update the header image - Revisit the design of Featured Articles to make it more readable - Improve navigation of the Archives and full HTML page Here are action items for Webdev: - /eclipse-newsletter should redirect to the must recent Edition - Fix breadcrumbs on Full Html page - Edition Form: Add better description, Update featured Committer and Featured Project fields, Filter the ads, Move Mailchimp html to Body field, Fix sidebar This is also captured in the following document: https://docs.google.com/document/d/1_MD7zDwxmnmFcaq9_PPho4qz3_TTYRn3RZtSx7xsuWI/edit#heading=h.obut8njiv62g We finally were able to successfully add the Newsroom website on staging and the Newsletter example is also on the website. You can find it here: https://newsroom-staging.eclipse.org/eclipse-newsletter username: testuser password: plaintext You can login to the website it self and look at the forms for Editions and Articles. https://newsroom-staging.eclipse.org/node/37974/edit https://newsroom-staging.eclipse.org/node/37976/edit Let me know if you have any questions, concerns or things you would like to change/update. Thanks! The Newsletter staging looks great! As per our discussion on our last meeting in terms of accessibility issues, I made some change on the header/banner as well as featured articles text boxes, that has been attached here. I believe with these enhancements it would looks great. Just one more request for more improvement on accessibility/usability considerations, I believe between the breadcrumbs, main article title and featured images we need a bit more padding. it looks a bit condensed. Please find attached including the new banner as well as the screen shots of the first fold. Thanks again for your support! Created attachment 285678 [details]
Header image
Created attachment 285679 [details]
Screen Shot for text boxes
I can't log in to https://newsroom-staging.eclipse.org I receive this error: {"error":"redirect_uri_mismatch","error_description":"The redirect URI provided is missing or does not match","error_uri":"http:\/\/tools.ietf.org\/html\/rfc6749#section-3.1.2"} @mehrnaz can we edit the header image to soften the line where the images are attached? Using a blend tool or filtering to black as a transition? It looks really good so far. Here is my feedback based on what I can see on the front end. On the landing page (ex https://newsroom-staging.eclipse.org/eclipse-newsletter/2020/december) - The entire image block for the spotlight articles should click through to the article (we don't need the ability to have different links in the summary) On the article page (ex https://newsroom-staging.eclipse.org/eclipse-newsletter/2020/december/traceability-management) - Left justify author images, we can then bump up the "share this article" a bit - When scaled down to mobile, text should start after author images (currently overlaps) Community Updates - Each article should have a separate page - These should be styled exactly like the spotlight article pages, but without the authors HTML email page (ex https://newsroom-staging.eclipse.org/eclipse-newsletter/2020/december/html)): - can we style it exactly like the current page (https://www.eclipse.org/community/eclipse_newsletter/2021/february/) Mehrnaz might provide an updated image but other than that it's fine (In reply to Shanda Giacomoni from comment #13) > I can't log in to https://newsroom-staging.eclipse.org > > I receive this error: > > {"error":"redirect_uri_mismatch","error_description":"The redirect URI > provided is missing or does not > match","error_uri":"http:\/\/tools.ietf.org\/html\/rfc6749#section-3.1.2"} I just added newsroom-staging.eclipse.org to our whitelist for login. Can you try now? You should see an error but you should be able to login now. I am working on removing that new error. (In reply to Christopher Guindon from comment #16) > (In reply to Shanda Giacomoni from comment #13) > > I can't log in to https://newsroom-staging.eclipse.org > > > > I receive this error: > > > > {"error":"redirect_uri_mismatch","error_description":"The redirect URI > > provided is missing or does not > > match","error_uri":"http:\/\/tools.ietf.org\/html\/rfc6749#section-3.1.2"} > > I just added newsroom-staging.eclipse.org to our whitelist for login. Can > you try now? > > You should see an error but you should be able to login now. I am working on > removing that new error. I have access. I'll check out the back end now. Questions about back-end: - How is the order of the 3 spotlight articles determined? Can we choose which one gets the big box on the left? - How is the order of the community updates determined? - We only upload 1 image/article, but it gets used for the newsletter landing page and the header of the article, but they have different aspect ratios. Is that image auto-cropped? If so, what aspect ratio and resolution should we be uploading? - Can authors be optional on the articles? We will obviously always have a drupal author, but we should be able to have no public-facing author for an article (In reply to Shanda Giacomoni from comment #18) > Questions about back-end: > > - How is the order of the 3 spotlight articles determined? Can we choose > which one gets the big box on the left? Right now they are ordered by date but we could order them by weight so you can choose the order. > - How is the order of the community updates determined? Some thing, they are ordered by date. But again we could add a Weight field that will let you determine the order. > - We only upload 1 image/article, but it gets used for the newsletter > landing page and the header of the article, but they have different aspect > ratios. Is that image auto-cropped? If so, what aspect ratio and resolution > should we be uploading? Drupal will scale and crop automatically the image depending if its a community news or a featured article. For example, these are the sizes for each sections. You can upload bigger images then that but Drupal will scale and crop them. Community News: 175x115 Featured Articles: 772x500 Note that I also set a size limit for the images. If the image is too big or too small, Drupal will complain and you will have to submit a new image with the proper sizes. > - Can authors be optional on the articles? We will obviously always have a > drupal author, but we should be able to have no public-facing author for an > article Yes, I can make it so that author are not required. Hi, Please disregard the previous banner and use this file Banner.jpg Created attachment 285681 [details]
Banner
(In reply to Eric Poirier from comment #19) > Right now they are ordered by date but we could order them by weight so you can choose the order. +1 for weighting both spotlight articles and community news (In reply to Mehrnaz Kokabi from comment #20) > Hi, Please disregard the previous banner and use this file Banner.jpg Hi Mehrnaz, I looked at the image you uploaded in comment #21 and it seems a bit odd to me. It looks like 2 images have been merged without the same resolution. The right side of the image is blurry. Hi Eric, let me check and get back to you shortly! Hi Eric, I checked the banner, I made the middle part blurry and dark for texts' better readability on purpose. As you said I have merged images and make the middle part blur and dark. (In reply to Shanda Giacomoni from comment #22) > (In reply to Eric Poirier from comment #19) > > > Right now they are ordered by date but we could order them by weight so you can choose the order. > > +1 for weighting both spotlight articles and community news It is now possible to change the order of the articles by their weight. This change is on staging. Created attachment 285784 [details]
Banner with better quality
Hi Eric, As per our conversation, please find attached the revised banner. Thanks for your support.
(In reply to Mehrnaz Kokabi from comment #27) > Created attachment 285784 [details] > Banner with better quality > > Hi Eric, As per our conversation, please find attached the revised banner. > Thanks for your support. I updated the staging site with the new image and the updated styles of the text in the header. https://newsroom-staging.eclipse.org/eclipse-newsletter/2020/december Let me know if there's anything else. Thanks. Thanks Eric! The banner looks great. Just have one more request for the section below the banner to add a dark box for texts. please refer to screen shots for text boxes (comment 12). Good Morning Eric, Just a quick note to follow up on the Newsletter progress. We appreciate if you can kindly keep us update. Thanks, Mehrnaz (In reply to Mehrnaz Kokabi from comment #30) > Good Morning Eric, > > Just a quick note to follow up on the Newsletter progress. We appreciate if > you can kindly keep us update. > Thanks, > Mehrnaz Hi Mehrnaz, I'm about to update staging with the last changes you requested (dark background for the text of the featured articles). I'll let you know once its there. Sorry for the delay on the update, we had issues yesterday to update the staging website. I added the latest update which adds a dark background to the featured articles. https://newsroom-staging.eclipse.org/eclipse-newsletter/2020/december Let me know if there's anything else. Thanks! Hi Eric, Thanks for all your help, it looks great! just one more small request could we add more padding below and above the title: "Bringing New Efficiencies to Automotive Software Development" May be 5px up and down please. Thanks again, (In reply to Mehrnaz Kokabi from comment #33) > Hi Eric, Thanks for all your help, it looks great! > just one more small request could we add more padding below and above the > title: "Bringing New Efficiencies to Automotive Software Development" May be > 5px up and down please. > Thanks again, Yes, no problem. But in order to reduce the back and forth of small changes, is there anything else you'd like me to update for the newsletter? This way I can make all the changes at the same time. Thanks. (In reply to Shanda Giacomoni from comment #15) > It looks really good so far. Here is my feedback based on what I can see on > the front end. > > On the landing page (ex > https://newsroom-staging.eclipse.org/eclipse-newsletter/2020/december) > - The entire image block for the spotlight articles should click through to > the article (we don't need the ability to have different links in the > summary) > > On the article page (ex > https://newsroom-staging.eclipse.org/eclipse-newsletter/2020/december/ > traceability-management) > - Left justify author images, we can then bump up the "share this article" a > bit > - When scaled down to mobile, text should start after author images > (currently overlaps) > > Community Updates > - Each article should have a separate page > - These should be styled exactly like the spotlight article pages, but > without the authors > > HTML email page (ex > https://newsroom-staging.eclipse.org/eclipse-newsletter/2020/december/html)): > - can we style it exactly like the current page > (https://www.eclipse.org/community/eclipse_newsletter/2021/february/) > Mehrnaz might provide an updated image but other than that it's fine My feedback from comment #15 still has to be integrated. Some of it is style, some is functionality, so I'm not sure if you want to do it all in the next round. (In reply to Shanda Giacomoni from comment #35) > (In reply to Shanda Giacomoni from comment #15) > > It looks really good so far. Here is my feedback based on what I can see on > > the front end. > > > > On the landing page (ex > > https://newsroom-staging.eclipse.org/eclipse-newsletter/2020/december) > > - The entire image block for the spotlight articles should click through to > > the article (we don't need the ability to have different links in the > > summary) > > > > On the article page (ex > > https://newsroom-staging.eclipse.org/eclipse-newsletter/2020/december/ > > traceability-management) > > - Left justify author images, we can then bump up the "share this article" a > > bit > > - When scaled down to mobile, text should start after author images > > (currently overlaps) > > > > Community Updates > > - Each article should have a separate page > > - These should be styled exactly like the spotlight article pages, but > > without the authors > > > > HTML email page (ex > > https://newsroom-staging.eclipse.org/eclipse-newsletter/2020/december/html)): > > - can we style it exactly like the current page > > (https://www.eclipse.org/community/eclipse_newsletter/2021/february/) > > Mehrnaz might provide an updated image but other than that it's fine > > My feedback from comment #15 still has to be integrated. Some of it is > style, some is functionality, so I'm not sure if you want to do it all in > the next round. Ah, completely skipped that comment, sorry about that. Yes, I'll do all those changes at the same time. Hi Shanda, I updated staging with the most recent comments. https://newsroom-staging.eclipse.org/eclipse-newsletter/2020/december Let me know if there's anything else. Thanks. 2 things for community updates: ex https://newsroom-staging.eclipse.org/eclipse-newsletter/2020/december/osgi-core-release-8-published 1. I cannot remove the author. It's saying it's a required field. 2. The related articles on this page - the whole box should link like they do on the main page And I don't see updated to the HTML page: > HTML email page (ex > https://newsroom-staging.eclipse.org/eclipse-newsletter/2020/december/html)): > - can we style it exactly like the current page > (https://www.eclipse.org/community/eclipse_newsletter/2021/february/) > Mehrnaz might provide an updated image but other than that it's fine I am looking for the content in the right column (subscribe button and link to archives). (In reply to Shanda Giacomoni from comment #38) > 2 things for community updates: > ex > https://newsroom-staging.eclipse.org/eclipse-newsletter/2020/december/osgi- > core-release-8-published > 1. I cannot remove the author. It's saying it's a required field. > 2. The related articles on this page - the whole box should link like they > do on the main page Ok I can make that change. > > And I don't see updated to the HTML page: > > > HTML email page (ex > > https://newsroom-staging.eclipse.org/eclipse-newsletter/2020/december/html)): > > - can we style it exactly like the current page > > (https://www.eclipse.org/community/eclipse_newsletter/2021/february/) > > Mehrnaz might provide an updated image but other than that it's fine > > I am looking for the content in the right column (subscribe button and link > to archives). Would you like to add the same banner as well? > Would you like to add the same banner as well?
Yes please.
@eric will we be using the newsroom for the April newsletter? If so, we will need it ready by the end of this week so we can start putting the content in. If not, Jacob will make a bug later this week for the newsletter content. (In reply to Shanda Giacomoni from comment #41) > @eric will we be using the newsroom for the April newsletter? If so, we will > need it ready by the end of this week so we can start putting the content > in. If not, Jacob will make a bug later this week for the newsletter content. Hi Shanda, I think it would be best if I do the newsletter manually this month and we can start doing it in the Newsroom next month. I sill have some changes to do and the code needs to go through review before going live. Hi Shanda, I updated staging with the following changes that you requested: Added the sidebar content on the HTML page. https://newsroom-staging.eclipse.org/eclipse-newsletter/2020/december/html Removed the required field for the authors so that you can leave that field blank for the Community news and also the related articles's block is now clickable. https://newsroom-staging.eclipse.org/eclipse-newsletter/2020/december/osgi-core-release-8-published Let me know if there's anything else. Thanks! > Added the sidebar content on the HTML page. > https://newsroom-staging.eclipse.org/eclipse-newsletter/2020/december/html > I am getting a 404 on the "All Eclipse Newsletters available here" link. It should link to the archives (/eclipse-newsletter/archives). Actually, if we can change the text to "Check out past Eclipse Newsletters" that would be even better. I'm also trying to test that the featured committer and featured project show up on the homepage, but I can't test that on the newsroom subdomain. And is the ad-block (below upcoming events in right column: https://newsroom-staging.eclipse.org/eclipse-newsletter/2020/december) just mocked up on staging or will this ad go live on prod? We don't want an ad there just yet. New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/home/+/179612 New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/home/+/179744 (In reply to Shanda Giacomoni from comment #44) > > Added the sidebar content on the HTML page. > > https://newsroom-staging.eclipse.org/eclipse-newsletter/2020/december/html > > > I am getting a 404 on the "All Eclipse Newsletters available here" link. It > should link to the archives (/eclipse-newsletter/archives). Actually, if we > can change the text to "Check out past Eclipse Newsletters" that would be > even better. I updated that on staging. > > I'm also trying to test that the featured committer and featured project > show up on the homepage, but I can't test that on the newsroom subdomain. > I'm currently having issues with staging.eclipse.org, I will post a screenshot of what I have locally. You'll notice that I added myself as the Featured committer of the month just for testing. > And is the ad-block (below upcoming events in right column: > https://newsroom-staging.eclipse.org/eclipse-newsletter/2020/december) just > mocked up on staging or will this ad go live on prod? We don't want an ad > there just yet. You can choose to whether or not add an ad to an Edition. If you decide that for a newsletter the ad is not ready, you can just leave the field blank. Created attachment 286216 [details]
Screeshot for FEatured committer and project
Here is a screenshot of eclipse.org/home with the updated featured committer and featured project coming from the latest edition on newsroom-staging.eclipse.org.
Let me know if you have any questions.
No further edits from me. I think it's ready to go to Chris for review. (In reply to Shanda Giacomoni from comment #49) > No further edits from me. I think it's ready to go to Chris for review. Sounds good! I'll do a final review of my code before handing it over. Thanks! I'm gonna close this bug since the Newsletter code is now on production in the Newsroom. I'm currently working on the May 2021 newsletter (Bug 573545) which is going to be hosted in the newsroom. Gerrit change https://git.eclipse.org/r/c/www.eclipse.org/home/+/179612 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/home.git/commit/?id=3e7ead839777c33c292ec12fa4b5cc403a2be26a New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/home/+/181135 Gerrit change https://git.eclipse.org/r/c/www.eclipse.org/home/+/181135 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/home.git/commit/?id=f4ad720360dffb7728c836e5916df38758efc79a New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/home/+/181191 Gerrit change https://git.eclipse.org/r/c/www.eclipse.org/home/+/181191 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/home.git/commit/?id=27350afaa35ba950ddb286937e10b66a8df0fd83 New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/community/+/181226 Gerrit change https://git.eclipse.org/r/c/www.eclipse.org/community/+/181226 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/community.git/commit/?id=8083e2798157b5139836f33f906e26cab6139b20 |