|
Description
Florian Barbin
New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/175113 New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/175902 New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/175953 New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/176151 Steps to validate (only in developement env or at least with source of org.eclipse.ui and org.eclipse.diagram.ui in your workspace): * Apply the patch of bugzilla [563117](https://bugs.eclipse.org/bugs/show_bug.cgi?id=563117) * Launch a runtime * Import projects from SourceAndTargetProjects.zip * Expand /SourceOfCopy/My.ecore * Create a new diagram "DiagType8 of MyPackage" * Move and resize the first 3 containers and move their border nodes * Save the session * Launch the action "Copy Rep" on MyPackage of SourceOfCopy project (action from contextual menu) * Launch the action "Paste Rep" on MyPackage of SourceOfCopy project (action from contextual menu) * Expected: A new diagram named "newDiag" is created under MyPackage. Open it. The layout is the same than "DiagType8 of MyPackage". This behavior was OK before the fix. It is only to ensure that "patch to test API" is OK. * Delete "newDiag" * Launch the action "Copy Rep" on MyPackage of SourceOfCopy project (action from contextual menu) * Expand /TargetOfCopy/My.ecore * Launch the action "Paste Rep" on MyPackage of TargetOfCopy project (action from contextual menu) * Expected: A new diagram named "newDiag" is created under MyPackage of TargetOfCopy project. Open it. The layout is the same than "DiagType8 of MyPackage". This behavior was KO before the fix (message in error log about source diagram description that doesn't match with target diagram description). * Delete "newDiag" * Create a new diagram "DiagType8 of MyPackagee" under MyPackage of TargetOfCopy project * Move and resize the first 3 containers and move their border nodes * Launch the action "Copy Rep" on MyPackage of SourceOfCopy project (action from contextual menu) * Launch the action "Paste Rep" on MyPackage of TargetOfCopy project (action from contextual menu) * Expected: The diagram under MyPackage of TargetOfCopy project has the same layout than the diagram under MyPackage of SourceOfCopy project. This behavior was KO before the fix (message in error log about source diagram description that doesn't match with target diagram description). * Delete both diagrams "DiagType8 of MyPackage" * Create a new diagram "DiagType8_unsync of MyPackage" under MyPackage of SourceOfCopy project * Add p1 with tool "Select packages to add" * Add C1-1 and C1-2 with tool "selectSubClass" * Save the session * Launch the action "Copy Rep" on MyPackage of SourceOfCopy project (action from contextual menu) * Launch the action "Paste Rep" on MyPackage of SourceOfCopy project (action from contextual menu) * Expected: A new diagram named "newDiag" is created under MyPackage of SourceOfCopy project. Open it. The layout is the same than "DiagType8_unsync of MyPackage". This behavior was KO before the fix. The border nodes was transformed into nodes. * Delete "newDiag" * Launch the action "Copy Rep" on MyPackage of SourceOfCopy project (action from contextual menu) * Expand /TargetOfCopy/My.ecore * Launch the action "Paste Rep" on MyPackage of TargetOfCopy project (action from contextual menu) * Expected: A new diagram named "newDiag" is created under MyPackage of TargetOfCopy project. Open it. The layout is the same than "DiagType8_unsync of MyPackage". This behavior was KO before the fix (message in error log about source diagram description that doesn't match with target diagram description). * Delete "newDiag" * Create a new diagram "DiagType8_unsync of MyPackage" under MyPackage of TargetOfCopy project * Add p1 with tool "Select packages to add" * Add C1-1 to "Container without children p1" with tool "selectSubClass" * Launch the action "Copy Rep" on MyPackage of SourceOfCopy project (action from contextual menu) * Launch the action "Paste Rep" on MyPackage of TargetOfCopy project (action from contextual menu) * Expected: The diagram under MyPackage of TargetOfCopy project has the same layout than the diagram under MyPackage of SourceOfCopy project. This behavior was KO before the fix (message in error log about source diagram description that doesn't match with target diagram description). * Delete both diagrams named "DiagType8_unsync of MyPackage" * Create a new diagram "DiagType8_unsyncBN of MyPackage" under MyPackage of SourceOfCopy project * Add C1-1 and C1-2 to "Container without children p1" with tool "selectSubClass" * Add C1-1-2 to "Container without children p1-1" with tool "selectSubClass" * Move and resize the first 3 containers and move their border nodes * Save the session * Launch the action "Copy Rep" on MyPackage of SourceOfCopy project (action from contextual menu) * Launch the action "Paste Rep" on MyPackage of SourceOfCopy project (action from contextual menu) * Expected: A new diagram named "newDiag" is created under MyPackage of SourceOfCopy project. Open it. The layout is the same than "DiagType8_unsyncBN of MyPackage". This behavior was KO before the fix. The border nodes was transformed into nodes and a "SWTException: Widget is disposed" is displayed into the ErrorLog view. * Delete "newDiag" * Launch the action "Copy Rep" on MyPackage of SourceOfCopy project (action from contextual menu) * Expand /TargetOfCopy/My.ecore * Launch the action "Paste Rep" on MyPackage of TargetOfCopy project (action from contextual menu) * Expected: A new diagram named "newDiag" is created under MyPackage of TargetOfCopy project. Open it. The layout is the same than "DiagType8_unsyncBN of MyPackage". This behavior was KO before the fix (message in error log about source diagram description that doesn't match with target diagram description). * Delete "newDiag" * Create a new diagram "DiagType8_unsyncBN of MyPackage" under MyPackage of TargetOfCopy project * Add C1-1 to "Container without children p1" with tool "selectSubClass" * Add C1-1-2 to "Container without children p1-1" with tool "selectSubClass" * Move and resize the first 3 containers and move their border nodes * Launch the action "Copy Rep" on MyPackage of SourceOfCopy project (action from contextual menu) * Launch the action "Paste Rep" on MyPackage of TargetOfCopy project (action from contextual menu) * Expected: The diagram under MyPackage of TargetOfCopy project has the same layout than the diagram under MyPackage of SourceOfCopy project. The border node C1-2 is also created as it is in the map filled by the "specific Copy/Paste Rep actions". This behavior was KO before the fix (message in error log about source diagram description that doesn't match with target diagram description). * Delete both diagrams named "DiagType8_unsyncBN of MyPackage" Created attachment 285533 [details]
SourceAndTargetProjects.zip
Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/176151 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=2a017de7cc51df1d29c7d0eec825803b9ad4c60b Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/175113 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0d0c6026b41d1318d5c8a7646c1659b201e70708 In this issue, another problem has been fixed concerning the copy/paste between a copy from a diagram from a session to a paste in a diagram of another session. New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/176388 New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/176463 Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/176463 was merged to [v6.4.x]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=faf6955f115283932d2d3803b6cbc8d403853faa Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/176388 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=683712c03917f7206ba342a2b0cccc2b95606ffc Validated with Sirius 6.4.2. Available in Sirius 6.4.2: http://download.eclipse.org/sirius/updates/releases/6.4.2 |