Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 570489

Summary: [GTK] Combo's selection background is broken after Combo.setBackground()
Product: [Eclipse Project] Platform Reporter: Alexandr Miloslavskiy <alexandr.miloslavskiy>
Component: SWTAssignee: Alexandr Miloslavskiy <alexandr.miloslavskiy>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: akurtakov, alexandr.miloslavskiy, ts-swt
Version: 4.11   
Target Milestone: 4.19 M3   
Hardware: PC   
OS: Linux   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=464228
https://bugs.eclipse.org/bugs/show_bug.cgi?id=543908
https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/175075
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=9811dcdeaa5af1aad13ab9c4e568491407d2783d
Whiteboard:
Attachments:
Description Flags
Test snippet
none
Comparison of before vs after patch none

Description Alexandr Miloslavskiy CLA 2021-01-19 13:35:25 EST
The problem is not new, I see it with ~3 years old SWT as well.
Comment 1 Alexandr Miloslavskiy CLA 2021-01-19 14:10:51 EST
Created attachment 285316 [details]
Test snippet
Comment 2 Alexandr Miloslavskiy CLA 2021-01-19 15:36:02 EST
Bug 464228 comment 18 discusses this problem and patch intended to fix it, but it seems to fail to work.
Comment 3 Alexandr Miloslavskiy CLA 2021-01-19 16:40:03 EST
Regression from Bug 543908. When testing old SWT versions, I was "lucky" to hit points where it was broken in between of working well.
Comment 4 Eclipse Genie CLA 2021-01-19 17:03:19 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/175075
Comment 5 Alexandr Miloslavskiy CLA 2021-01-19 17:05:41 EST
Created attachment 285317 [details]
Comparison of before vs after patch

Improved test snippet is now available inside patch.
Comment 7 Alexandr Miloslavskiy CLA 2021-01-20 09:34:04 EST
Thanks for a quick review!
Comment 8 Alexandr Miloslavskiy CLA 2021-02-23 08:01:19 EST
Verified in S-4.19M3-202102171800 using test snippet 'Bug570489_Gtk_ComboSetBackground'