Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 570433

Summary:	Improve Package Visibility text in PDE editor
Product:	[Eclipse Project] PDE	Reporter:	Lars Vogel <Lars.Vogel>
Component:	UI	Assignee:	Lars Vogel <Lars.Vogel>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Lars.Vogel, tjwatson, Vikas.Chandra
Version:	4.14
Target Milestone:	4.19 M2
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/175108 https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/175110 https://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=60287c56732cd42e343d718a3846af5aaa70c237 https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=d61590666055fec14394b0e07e63a8a17582567e
Whiteboard:	4.19 M2
Bug Depends on:
Bug Blocks:	569282

Description Lars Vogel

2021-01-18 03:27:26 EST

Currently it says:

If the runtime is in strict mode, the selected package is:
* visible...
* hidden from all...

---------

Is this text actually correct? 

I think a better text is:

The select package is:
* public API
* provisional API generating warnings, except for:

Comment 1 Lars Vogel

2021-01-18 03:28:43 EST

Tom, can you advice? Especially "hidden from all plug-ins except" seems wrong as x-internal allows usage from outside.

Comment 2 Thomas Watson

2021-01-20 09:25:45 EST

(In reply to Lars Vogel from comment #1)
> Tom, can you advice? Especially "hidden from all plug-ins except" seems
> wrong as x-internal allows usage from outside.

I think this has gone largely unnoticed because nobody ever used "strict mode".  That option has not been supported by Equinox since the Luna release.  The only thing x-internal and x-friends gets you is warnings in PDE.  These are not standard directives in OSGi.

The reason I took support away is that is was going to be very difficult to keep it working when moving to the standard OSGi Resolver specification implementation.  No other OSGi framework implementation would recognize the directives either so the exports will all be available and can be imported with no restrictions on other frameworks, so we had an inconsistency in behavior.  That is why it was decided to take away "strict mode".  Obviously nobody noticed so I think it was a good decision to remove that technical dept from the framework.

With that said, I think Lars is correct and I am in favor of the change as he suggests.

Comment 3 Eclipse Genie

2021-01-20 10:28:23 EST

New Gerrit change created: https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/175108

Comment 4 Eclipse Genie

2021-01-20 10:45:31 EST

New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/175110

Comment 5 Eclipse Genie

2021-01-20 10:49:45 EST

Gerrit change https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/175110 was merged to [master].
Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=60287c56732cd42e343d718a3846af5aaa70c237

Comment 6 Eclipse Genie

2021-01-21 06:29:40 EST

Gerrit change https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/175108 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=d61590666055fec14394b0e07e63a8a17582567e

Comment 7 Vikas Chandra

2021-01-28 07:22:39 EST

verified in
Version: 2021-03 (4.19)
Build id: I20210127-1800