Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 570390

Summary: org.eclipse.ui.internal.misc.TextMatcher does not handle pattern ending in whitespace correctly
Product: [Eclipse Project] Platform Reporter: Sebastian Ratz <sebastian.ratz>
Component: UIAssignee: Sebastian Ratz <sebastian.ratz>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Lars.Vogel, twolf
Version: 4.17   
Target Milestone: 4.19 M3   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/174888
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2abcf7451cac96ef70f0667cb04b7251a8f4ea42
Whiteboard:
Bug Depends on:    
Bug Blocks: 569282    

Description Sebastian Ratz CLA 2021-01-15 08:44:47 EST 
Regression of bug 563485 / Refactor org.eclipse.ui.internal.misc.StringMatcher:

Steps to reproduce:
- File -> New -> Other
- Type 'JUnit ' (trailing space!)

In 4.16, using the old org.eclipse.ui.internal.misc.StringMatcher, the results 'JUnit Test Case' and 'JUnit Test Suite' are found.

In 4.17, using the new org.eclipse.ui.internal.misc.TextMatacher, no results are found.

The old org.eclipse.ui.internal.misc.StringMatcher trimmed in incoming pattern, org.eclipse.ui.internal.misc.TextMatacher does not.
Comment 1 Eclipse Genie CLA 2021-01-15 08:47:34 EST 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/174888
Comment 3 Sebastian Ratz CLA 2021-01-18 04:27:15 EST 
Verified / tested in build I20210117-1940.