Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 570382

Summary: [Nebula Grid] Cell selection implementation incomplete
Product: [RT] RAP Reporter: Manuel Mall <manuel.mall>
Component: JFaceAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: manuel.mall
Version: 3.16   
Target Milestone: 3.16 M1   
Hardware: PC   
OS: Windows 10   
See Also: https://git.eclipse.org/r/c/rap/org.eclipse.rap/+/174967
https://git.eclipse.org/c/rap/org.eclipse.rap.git/commit/?id=088bc6f05c8d25e6a746ed2a2c297979c117c840
Whiteboard:

Description Manuel Mall CLA 2021-01-15 03:11:42 EST 
The GridTableViewer class still contains commented out code that should have been reinstated with the development under Bug 494517.

For example:

public ISelection getSelection() {
    // if( !grid.isCellSelectionEnabled() ) {
      IStructuredSelection selection = ( IStructuredSelection )super.getSelection();
      Object el = null;
      if( grid.getFocusItem() != null && !grid.getFocusItem().isDisposed() ) {
        el = grid.getFocusItem().getData();
      }
      return new SelectionWithFocusRow( selection.toList(), el, getComparer() );
    // } else {
    //   return createCellSelection();
    // }
  }

One effect of this is that when calling StructuredViewer.refresh() the cell selection is not preserved as it should.

I have not checked if the GridTreeViewer class also still has commented out code that should be reinstated.
Comment 1 Eclipse Genie CLA 2021-01-18 03:57:40 EST 
New Gerrit change created: https://git.eclipse.org/r/c/rap/org.eclipse.rap/+/174967