Bugzilla – Full Text Bug Listing
| Summary: | [Big Sur] Different color for inactive selection background in Eclipse dark theme | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Lakshmi P Shanmugam <lshanmug> | ||||
| Component: | SWT | Assignee: | Lakshmi P Shanmugam <lshanmug> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | a.nesheret, ben.cox, niraj.modi, sarika.sinha | ||||
| Version: | 4.18 | Flags: | sarika.sinha:
review+
|
||||
| Target Milestone: | 4.18 RC2 | ||||||
| Hardware: | PC | ||||||
| OS: | Mac OS X | ||||||
| See Also: |
https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/172888 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=0b7996a256df44f498e70c0af9da8095fd6b1d9b https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/173020 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=a619411c5d0d6467d0725acb2b7d9dbec7707aca |
||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 565691 | ||||||
| Attachments: |
|
||||||
|
Description
Lakshmi P Shanmugam
This is seen only in Eclipse when in dark theme, looks like the color is being initialised too early and the color for light theme is being used. Created attachment 284907 [details]
incorrect inactive selection color
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/172888 @Sarika, This looks bad on Eclipse in BigSur and is a regression from Bug 565969. Looks good for RC2. Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/172888 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=0b7996a256df44f498e70c0af9da8095fd6b1d9b Thanks Niraj and Sarika for reviews. Verified in I20201127-1010 Saw this problem again today with latest Eclipse. It still happens if the Package Explorer is open and shows selection after (re)starting Eclipse. It can be fixed by closing Package Explorer and restarting Eclipse. On debugging saw that the Package Explorer Tree is drawn once before Eclipse is set to dark theme, this causes Display.getSecondarySelectedControlColor() to be set with the color for the light theme, instead of dark theme. The complete fix would be to reinitialise all the colours when the theme is changed, but I don't want to make this change now in RC2. Will only reset the affected tree selection colors now, only look at the complete fix for 4.19. New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/173020 Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/173020 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=a619411c5d0d6467d0725acb2b7d9dbec7707aca Fixed in I20201130-1800. Verified with I20201202-1800 |