Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 568108

Summary:	[Win32][DarkTheme] Support Windows 10 - 2021 Spring Update
Product:	[Eclipse Project] Platform	Reporter:	Alexandr Miloslavskiy <alexandr.miloslavskiy>
Component:	SWT	Assignee:	Platform-SWT-Inbox <platform-swt-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	alexandr.miloslavskiy, Lars.Vogel, ts-swt
Version:	4.18
Target Milestone:	---
Hardware:	PC
OS:	Windows 10
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=562043 https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/171125 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=ab8ece62ce0407305d99c0713a94461a49cf9788 https://bugs.eclipse.org/bugs/show_bug.cgi?id=444560 https://bugs.eclipse.org/bugs/show_bug.cgi?id=576614
Whiteboard:

Description Alexandr Miloslavskiy

2020-10-22 09:47:10 EDT

Windows 10 October 2020 Update introduces some changes to native Dark Theme after almost 2 years of inactivity. SWT needs to be updated to recognize the new undocumented APIs.

Comment 1 Alexandr Miloslavskiy

2020-10-22 10:10:31 EDT

Lars, don't you worry, you won't dodge reviewing it even if you wanted to be forgotten :)

Comment 2 Lars Vogel

2020-10-22 10:11:45 EDT

(In reply to Alexandr Miloslavskiy from comment #1)
> Lars, don't you worry, you won't dodge reviewing it even if you wanted to be
> forgotten :)

:-)

Comment 3 Eclipse Genie

2020-10-22 10:23:22 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/171125

Comment 4 Eclipse Genie

2020-10-22 11:23:49 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/171125 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=ab8ece62ce0407305d99c0713a94461a49cf9788

Comment 5 Alexandr Miloslavskiy

2020-10-22 13:23:03 EDT

Turns out, I have mistaken 20H2 preview with 21H1 preview. So this patch actually prepares for 21H1 (Win10 - 2021 Spring update). 20H2 (Win10 - 2020 October update) doesn't need any changes and will work with the old code as well.