Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 568029

Summary:	Remove ComparePlugin
Product:	[Eclipse Project] Platform	Reporter:	Lars Vogel <Lars.Vogel>
Component:	Team	Assignee:	Lars Vogel <Lars.Vogel>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Lars.Vogel, ma.becker
Version:	4.17
Target Milestone:	4.18 M3
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/170995 https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/171005 https://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=b74f7528de85755033a3a40f0a70439287c61f39 https://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=a65e4561cb976450a9143634b5c0fd67c19f84b9 https://bugs.eclipse.org/bugs/show_bug.cgi?id=570348
Whiteboard:
Bug Depends on:
Bug Blocks:	566485

Description Lars Vogel

2020-10-20 05:38:12 EDT

Removing ComparePlugin requires the usage of our standard logging and moving isCappingDisabled to a util class.

Comment 1 Eclipse Genie

2020-10-20 05:39:33 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/170995

Comment 2 Eclipse Genie

2020-10-20 07:07:51 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/171005

Comment 3 Eclipse Genie

2020-10-21 04:05:54 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/170995 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=b74f7528de85755033a3a40f0a70439287c61f39

Comment 4 Eclipse Genie

2020-10-22 03:49:21 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/171005 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=a65e4561cb976450a9143634b5c0fd67c19f84b9

Comment 5 Matthias Becker

2021-01-13 11:32:30 EST

@Lars: Is there a reason why you did not remove the usages of
CompareUIPlugin#getDialogSettings e.g. in PatchWizard?

Comment 6 Lars Vogel

2021-01-13 11:36:21 EST

(In reply to Matthias Becker from comment #5)
> @Lars: Is there a reason why you did not remove the usages of
> CompareUIPlugin#getDialogSettings e.g. in PatchWizard?

No, please provide Gerrit.