Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 567900

Summary: Screen reader link to #content on web page header
Product: Community Reporter: Andrew Johnson <andrew_johnson>
Component: WebsiteAssignee: phoenix.ui <phoenix.ui-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: minor    
Priority: P3 CC: chris.guindon
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows 10   
See Also: https://git.eclipse.org/r/c/www.eclipse.org/eclipse.org-common/+/170820
https://git.eclipse.org/c/www.eclipse.org/eclipse.org-common.git/commit/?id=bad3dc6c694f1a99e7f9403bd3550a19161fe621
Whiteboard:

Description Andrew Johnson CLA 2020-10-15 04:40:49 EDT 
On Eclipse websites there is a screen reader link:

<a class="sr-only" href="#content">Skip to main content</a>

but www.eclipse.org doesn't have that fragment identifier so it goes to the top:
https://www.eclipse.org/#content

www.eclipse.org/mat has:

        <div class="novaContent container legacy-page" id="novaContent">
          <div class="row"><div class="col-md-18 main-col-content"><div id="maincontent">
	<div id="midcolumn">
		<h1>Memory Analyzer (MAT)</h1>

but I don't know how the convention of having a id="maincontent" came about. I can add a id="content" for MAT - but there are other websites too: http://www.eclipse.org/mat

https://www.eclipse.org/eclipse.org-common/themes/solstice/html_template/index.php?theme=default&layout=default

doesn't seem to have that #content target. Perhaps it should go on the <h1> element or the banner should link to maincontent.

Is there a convention that Eclipse web pages should have id="content" somewhere if they have the standard banner? Is it documented somewhere?

https://www.eclipse.org/eclipse.org-common/themes/solstice/docs/
has a link to
https://www.eclipse.org/eclipse.org-common/themes/solstice/html_template/index.php?theme=default&layout=default

without an id="content".
Comment 1 Christopher Guindon CLA 2020-10-15 08:19:01 EDT 
(In reply to Andrew Johnson from comment #0)

> but I don't know how the convention of having a id="maincontent" came about.
> I can add a id="content" for MAT - but there are other websites too:
> http://www.eclipse.org/mat

If we want to change the current behivor, we should do it in our theme layer. It would be too much work to update every page on our site.

> Is there a convention that Eclipse web pages should have id="content"
> somewhere if they have the standard banner? Is it documented somewhere?

There is no convention but I don't think this is something we want website maintainers to do. Let's try to find a solution where we can make this work with the eclipse.org theme.

How about we add #content to <main>?
Comment 2 Eclipse Genie CLA 2020-10-15 08:20:08 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/eclipse.org-common/+/170820
Comment 4 Christopher Guindon CLA 2020-10-15 11:11:12 EDT 
Done!

Please re-open if this does not fix your issue!