Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 567862

Summary:	[Big Sur] SWT.ICON_INFORMATION returning a generic icon
Product:	[Eclipse Project] Platform	Reporter:	Ian Sentina <ildsentina>
Component:	SWT	Assignee:	Lakshmi P Shanmugam <lshanmug>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	lshanmug, p.beauvoir
Version:	4.18
Target Milestone:	4.18 M3
Hardware:	Macintosh
OS:	Mac OS X
See Also:	https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/171513 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=539fcb409aa94b548eb95ea792f9f5a63fe9ca70
Whiteboard:
Bug Depends on:
Bug Blocks:	565691

Description Ian Sentina

2020-10-14 03:36:07 EDT

Using macOS 11 Big Sur Beta 9 (20A5384c).

Retrieving the information icon (also question and working) results into a generic file icon.

Seems like the deprecated method GetIconRefFromTypeInfo may be need to be replaced by iconForContentType instead.

(https://developer.apple.com/documentation/appkit/nsworkspace/3553230-iconforcontenttype?language=objc)

Comment 1 Eclipse Genie

2020-10-30 11:30:09 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/171513

Comment 2 Eclipse Genie

2020-11-05 05:53:10 EST

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/171513 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=539fcb409aa94b548eb95ea792f9f5a63fe9ca70

Comment 3 Lakshmi P Shanmugam

2020-11-05 05:55:52 EST

The fix uses NSImage.imageNamed() instead of GetIconRefFromTypeInfo() where ever possible.

Comment 4 Phil Beauvoir

2020-11-05 06:20:41 EST

Hi, I'm not seeing the fix for this in I20201105-0230, is it in a later build?

Comment 5 Lakshmi P Shanmugam

2020-11-05 06:26:03 EST

(In reply to Phil Beauvoir from comment #4)
> Hi, I'm not seeing the fix for this in I20201105-0230, is it in a later
> build?

Hi, The fix was merged today, so it'll be available in tomorrow's I-build.

Comment 6 Phil Beauvoir

2020-11-06 08:56:57 EST

(In reply to Lakshmi P Shanmugam from comment #5)
> (In reply to Phil Beauvoir from comment #4)
> > Hi, I'm not seeing the fix for this in I20201105-0230, is it in a later
> > build?
> 
> Hi, The fix was merged today, so it'll be available in tomorrow's I-build.

Tested this on I20201105-1800 and can confirm the fix. Thanks, Lakshmi!

Comment 7 Lakshmi P Shanmugam

2020-11-17 11:29:53 EST

Verified with I20201117-0600.