Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 567610

Summary:	Jakarta Transactions project committer does not have write access on a Jakarta Transactions GitHub repository
Product:	Community	Reporter:	Tom Jenkinson <tom.jenkinson>
Component:	GitHub	Assignee:	Eclipse Webmaster <webmaster>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	lance.andersen
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:

Description Tom Jenkinson

2020-10-05 10:22:06 EDT

Hi,

Lance Anderson is a project committer on Jakarta Transactions:
https://projects.eclipse.org/projects/ee4j.jta/who
https://projects.eclipse.org/content/lance-andersen-committer-eclipse-project-jta

The GitHub account LanceAnderson does not seem to have write access to the repo: https://github.com/LanceAndersen as you can see on a PR that GitHub user LanceAnderson has provided a review but it does not allow me to merge the PR:
https://github.com/eclipse-ee4j/jta-api/pull/178

I cannot independently verify that the GitHub account is indeed https://projects.eclipse.org/content/lance-andersen-committer-eclipse-project-jta  and I am not sure how Eclipse do that - please can you review whatever is necessary to do that and then make changes so that Lance can have commit access to the project repository?

Many thanks,
Tom

Comment 1 Eclipse Webmaster

2020-10-05 13:54:11 EDT

The issue appears to be that Lance has not added his Github ID to his Eclipse.org account (https://accounts.eclipse.org -> Edit Profile -> Social Media links -> Github Username ) .  Once that's done our sync process should invite Lance to join the relevant Github team when it next runs.

-M.

Comment 2 Lance Andersen

2020-10-06 06:53:11 EDT

(In reply to Eclipse Webmaster from comment #1)
> The issue appears to be that Lance has not added his Github ID to his
> Eclipse.org account (https://accounts.eclipse.org -> Edit Profile -> Social
> Media links -> Github Username ) .  Once that's done our sync process should
> invite Lance to join the relevant Github team when it next runs.
> 
> -M.

My GitHub username is set to LanceAndersen, is there something else that needs to be done?

Comment 3 Lance Andersen

2020-10-06 06:59:40 EDT

So I think I now messed myself up :-(

I have 2 Eclipse accounts lance@luckydogtennis.com and lance.andersen@oracle.com

I must have been logged into lance@luckydogtennis.com and I changed who I worked for from other to Oracle and now I can no longer log into either account.

Please help!

Comment 4 Lance Andersen

2020-10-06 07:25:54 EDT

SO I think I have sorted out my accounts (I hope).  I removed my GitHub username from my personal Eclipse Account and added it to my Oracle Eclipse account.

However, even after doing that and approving the PR it still seems the merge is blocked.  Suggestions?

Comment 5 Tom Jenkinson

2020-10-06 08:25:53 EDT

Thanks for the update Lance.

Please can someone from Eclipse confirm the frequency of the sync process? https://accounts.eclipse.org/user/204228#tab-projects looks like it could work to me.

I hope Lance you will get an invite (I assume email) to join the GitHub team once the sync process executes which I guess you will need to accept for you to get the permissions.

Comment 6 Eclipse Webmaster

2020-10-07 16:06:46 EDT

(In reply to Tom Jenkinson from comment #5)

The sync process runs every couple of hours, and a quick look at the group membership on Github shows Lance as a member of the expected team.

-M.

Comment 7 Tom Jenkinson

2020-10-08 07:12:43 EDT

Thanks for the update!

I think looking at https://github.com/eclipse-ee4j/jta-api/pull/178 that a review from Lance now would allow GitHub merges as I think the "green tick" mark is different to how the positive review symbol looked before (but I can't be sure).