Bugzilla – Full Text Bug Listing
| Summary: | NPE in DesktopFileWriter.escapeSpaces | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Christian Dietrich <christian.dietrich.opensource> |
| Component: | UI | Assignee: | Andrey Loskutov <loskutov> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | loskutov, wearybands |
| Version: | 4.17 | ||
| Target Milestone: | 4.18 M3 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: |
https://bugs.eclipse.org/bugs/show_bug.cgi?id=530835 https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/171409 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=13bd8d6d0429e44bd59cd28dbab4fea566442396 https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/171438 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b78036673f090e2042afc4964a38556a197b7c76 |
||
| Whiteboard: | |||
|
Description
Christian Dietrich
affects M3, Problem also was there in M2 looks like there is no eclipse.launcher system property when you run tests on windows there is a fallback implemented using
System.getProperty("eclipse.home.location")
*** Bug 568165 has been marked as a duplicate of this bug. *** It also happens in linux, I am using ubuntu 18.04 and I see this issue, any solution for linux? @Umair Iqba this bug is a about linux. the alternate paths on windows dont exist on linux. Do you mean it is fixed/implemented? I am using eclipse official release 2020-09, will this issue be fixed in that official release or I have to wait for the next official eclipse release? no this is a open bug on linux for WINDOWS there are alternative treatments but NOT FOR LINUX Ok, I don't see the issue on windows but only on linux. Is there any ETA for the fix ? as nobody seems to work on it: NO I can't see this misery anymore, I will push a patch in a moment. Thank you, Will this fix be available in eclipse 2020-09? My target definitions for eclipse looks like
<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
<repository location="http://my.server.com:8081/nexus/content/repositories/eclipse-2020-09"/>
<unit id="org.eclipse.cdt.build.crossgcc.feature.group" version="0.0.0"/>
<unit id="org.eclipse.cdt.debug.gdbjtag.feature.group" version="0.0.0"/>
<unit id="org.eclipse.cdt.feature.group" version="0.0.0"/>
<unit id="org.eclipse.cdt.launch.remote.feature.group" version="0.0.0"/>
<unit id="org.eclipse.egit.feature.group" version="0.0.0"/>
<unit id="org.eclipse.equinox.sdk.feature.group" version="0.0.0"/>
<unit id="org.eclipse.jdt.feature.group" version="0.0.0"/>
<unit id="org.eclipse.jst.enterprise_ui.feature.feature.group" version="0.0.0"/>
<unit id="org.eclipse.swtbot.eclipse.feature.group" version="0.0.0"/>
<unit id="org.eclipse.swtbot.eclipse.gef.feature.group" version="0.0.0"/>
<unit id="org.eclipse.swtbot.feature.group" version="0.0.0"/>
<unit id="org.eclipse.swtbot.ide.feature.group" version="0.0.0"/>
<unit id="org.eclipse.tcf.cdt.feature.feature.group" version="0.0.0"/>
<unit id="org.eclipse.tcf.te.tcf.feature.feature.group" version="0.0.0"/>
<unit id="org.eclipse.tcf.te.tcf.launch.cdt.feature.feature.group" version="0.0.0"/>
<unit id="org.eclipse.tm.terminal.feature.feature.group" version="0.0.0"/>
<unit id="org.eclipse.wst.xml_ui.feature.feature.group" version="0.0.0"/>
</location>
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/171409 (In reply to Umair Iqbal from comment #12) > Thank you, Will this fix be available in eclipse 2020-09? For sure not, except you would backport & build your own SDK. Hmmm, so it means I have to wait for the next official eclipse release if I don't want to build my own SDK Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/171409 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=13bd8d6d0429e44bd59cd28dbab4fea566442396 (In reply to Umair Iqbal from comment #15) > Hmmm, so it means I have to wait for the next official eclipse release if I > don't want to build my own SDK You simply could add "-Declipse.launcher=/dev/null" to the test configuration, I believe that should work. @Christian: could you please verify if your test job will work with the next integration build? unfortunately we dont use ibuild will see if i can fake a build on friday (have to rework target file) (In reply to Andrey Loskutov from comment #17) > (In reply to Umair Iqbal from comment #15) > > Hmmm, so it means I have to wait for the next official eclipse release if I > > don't want to build my own SDK > > You simply could add "-Declipse.launcher=/dev/null" to the test > configuration, I believe that should work. By test configuration you mean adding this as an option to the java command that executes the tests like java -Declipse.launcher=/dev/null -XX:+CMSClassUnloadingEnabled -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=8000 -jar /eclipse/plugins/org.eclipse.equinox.launcher_1.5.800.v20200727-1323.jar org.eclipse.equinox.launcher.Main -swtbot -application org.eclipse.swtbot.eclipse.junit.headless.swtbottestapplication -product org.eclipse.platform.ide -testApplication /eclipse/plugins/org.eclipse.ui.ide.workbench -data /eclipse/workspace -testPluginName org.my.ui.stt.test -className org.my.ui.test.collection.window.WindowTests (In reply to Umair Iqbal from comment #20) > By test configuration you mean adding this as an option to the java command > that executes the tests like > > java -Declipse.launcher=/dev/null -XX:+CMSClassUnloadingEnabled Sure. i can confirm this fixed using latest ibuild New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/171438 Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/171438 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b78036673f090e2042afc4964a38556a197b7c76 |