Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 566049

Summary:	Retire scrubbing of old e4 commands in ModelMigrationProcessor
Product:	[Eclipse Project] Platform	Reporter:	Rolf Theunissen <rolf.theunissen>
Component:	UI	Assignee:	Rolf Theunissen <rolf.theunissen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Lars.Vogel, sarika.sinha
Version:	4.16
Target Milestone:	4.17 M3
Hardware:	PC
OS:	Windows 10
See Also:	https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/167669 https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/167671 https://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=c298a135ea40897e9864c364f9345a18da3e7c77 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2e7af7e43227118d01a80ce190fbbc20230107f7
Whiteboard:
Bug Depends on:
Bug Blocks:	563542

Description Rolf Theunissen

2020-08-13 14:28:23 EDT

The org.eclipse.ui.internal.ModelMigrationProcessor was introduced in Bug 411602 to remove old commands.

Similarly to Bug 565948, this only applies to old workspaces that have never been opened with a recent (> 4.4) version of Eclipse.

Suggest to remove the processor

Comment 1 Eclipse Genie

2020-08-13 14:30:39 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/167669

Comment 2 Eclipse Genie

2020-08-13 14:48:55 EDT

New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/167671

Comment 3 Lars Vogel

2020-08-14 03:08:27 EDT

We also have WorkbenchMigrationProcessor. Shall we also retire this one?

Comment 4 Rolf Theunissen

2020-08-14 04:27:56 EDT

(In reply to Lars Vogel from comment #3)
> We also have WorkbenchMigrationProcessor. Shall we also retire this one?

That processor migrates E3 workbench models to E4 workbench models. So it is even older then the other migrators. It might be that the full org.eclipse.ui.internal.e4.migration package can be removed then.
We should do that in another bug.

Comment 5 Lars Vogel

2020-08-14 05:41:51 EDT

(In reply to Rolf Theunissen from comment #4)
> (In reply to Lars Vogel from comment #3)
> > We also have WorkbenchMigrationProcessor. Shall we also retire this one?
> 
> That processor migrates E3 workbench models to E4 workbench models. So it is
> even older then the other migrators. It might be that the full
> org.eclipse.ui.internal.e4.migration package can be removed then.
> We should do that in another bug.

Bug 566074

Comment 6 Eclipse Genie

2020-08-14 15:38:24 EDT

Gerrit change https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/167671 was merged to [master].
Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=c298a135ea40897e9864c364f9345a18da3e7c77

Comment 7 Eclipse Genie

2020-08-14 16:10:53 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/167669 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2e7af7e43227118d01a80ce190fbbc20230107f7

Comment 8 Sarika Sinha

2020-11-24 01:52:36 EST

ReadMe should have updated that we don't support migration. 

ReadMe for 4.17 states otherwise, I am updating it for 4.18.