Bugzilla – Full Text Bug Listing
| Summary: | ECA validation seems broken today | ||
|---|---|---|---|
| Product: | Community | Reporter: | Joakim Erdfelt <joakim.erdfelt> |
| Component: | GitHub | Assignee: | Eclipse Webmaster <webmaster> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | chris.guindon, gregw |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | |||
|
Description
Joakim Erdfelt
The ECA validation check still seems broken. The error mentions "Anonymous", but none of the commits from the user has that word. [joakim@hyperion]$ git clone git@github.com:travisspencer/jetty.project.git travisspencer-jetty.project Cloning into 'travisspencer-jetty.project'... remote: Enumerating objects: 20, done. remote: Counting objects: 100% (20/20), done. remote: Compressing objects: 100% (12/12), done. remote: Total 575157 (delta 1), reused 14 (delta 0), pack-reused 575137 Receiving objects: 100% (575157/575157), 132.54 MiB | 35.01 MiB/s, done. Resolving deltas: 100% (232362/232362), done. [joakim@hyperion]$ cd travisspencer-jetty.project/ [joakim@hyperion travisspencer-jetty.project][jetty-9.4.x]$ git checkout fix/jetty-9.4.x/5104-incorrect-protocol-version-in-Via-header Branch 'fix/jetty-9.4.x/5104-incorrect-protocol-version-in-Via-header' set up to track remote branch 'fix/jetty-9.4.x/5104-incorrect-protocol-version-in-Via-header' from 'origin'. Switched to a new branch 'fix/jetty-9.4.x/5104-incorrect-protocol-version-in-Via-header' [joakim@hyperion travisspencer-jetty.project][fix/jetty-9.4.x/5104-incorrect-protocol-version-in-Via-header]$ git log --format=fuller -2 commit f0713255aed93e75d9dc8a49ac239206a78d11a4 (HEAD -> fix/jetty-9.4.x/5104-incorrect-protocol-version-in-Via-header, origin/fix/jetty-9.4.x/5104-incorrect-protocol-version-in-Via-header) Author: Travis Spencer <travis@cu**ty.io> AuthorDate: Sat Aug 1 11:25:48 2020 +0200 Commit: Travis Spencer <travis@cu**ty.io> CommitDate: Mon Aug 3 08:15:19 2020 +0200 Issue #5104 - Fix protocol version in Via header to work with H2 and other protocols Bug: https://github.com/eclipse/jetty.project/issues/5104 Signed-off-by: Travis Spencer <travis@cu**ty.io> commit 66ec16006edb96a5904f60b9aa067dfeb4217528 (origin/jetty-9.4.x, origin/HEAD, jetty-9.4.x) Author: Greg Wilkins <gregw@we**ide.com> AuthorDate: Thu Jul 30 17:58:34 2020 +0200 Commit: GitHub <noreply@github.com> CommitDate: Thu Jul 30 17:58:34 2020 +0200 Issue #5088 Review ContextHandler locking (#5094) * Issue #5088 Review ContextHandler locking ... (email addresses partial obfuscated) The screenshots (see PR discussion) from the user show that they have a valid ECA signed, and the email address is properly registered. The manual ECA validation check against the PR also fails. The manual ECA validation against their email address also fails. This doesn't make sense. Bump (7-days later), the ECA processing for this PR is still broken. Bump! This is holding up some contributions/releases (In reply to Joakim Erdfelt from comment #0) > The ECA validation process seems broken today. > > See conversation at the following PR > > https://github.com/eclipse/jetty.project/pull/5107 I don't believe it's broken. (In reply to Joakim Erdfelt from comment #1) > The ECA validation check still seems broken. > > The error mentions "Anonymous", but none of the commits from the user has > that word. "Anonymous" usually means that the ECA validation service was unable to link a contribution with an Eclipse Account. I did a quick search in our database and I was not able to find an Eclipse account with the email address travis@cu**ty.io. Please note that I did search with the real email address from Github API: https://api.github.com/repos/eclipse/jetty.project/pulls/5107/commits The contributor must use the email address from their Eclipse account. It's also a good idea for users to share their Github ID with us via the Edit my profile page on accounts.eclipse.org. Please let me know if you have any questions! (In reply to Christopher Guindon from comment #4) > (In reply to Joakim Erdfelt from comment #0) > > The ECA validation process seems broken today. > > > > See conversation at the following PR > > > > https://github.com/eclipse/jetty.project/pull/5107 > > I don't believe it's broken. (In reply to Joakim Erdfelt from comment #1) > > The ECA validation check still seems broken. > > > > The error mentions "Anonymous", but none of the commits from the user has > > that word. > > "Anonymous" usually means that the ECA validation service was unable to link > a contribution with an Eclipse Account. > > I did a quick search in our database and I was not able to find an Eclipse > account with the email address travis@cu**ty.io. > > Please note that I did search with the real email address from Github API: > https://api.github.com/repos/eclipse/jetty.project/pulls/5107/commits If you look at the PR linked, you'll see several screenshots from the user with the output of their accounts.eclipse.org web page, the email address etc is clearly shown as `travis@cu**ty.io` same as what's in the actual commit, and what's in the api.github.com results you linked. But they do not validate, either automatically, or manually. The user also states in https://github.com/eclipse/jetty.project/pull/5107#issuecomment-667574293 That their eclipse user id is: tspencer5c1 Which shows their ECA is signed - https://accounts.eclipse.org/users/tspencer5c1 (In reply to Christopher Guindon from comment #4) > (In reply to Joakim Erdfelt from comment #0) > > The ECA validation process seems broken today. > > > > See conversation at the following PR > > > > https://github.com/eclipse/jetty.project/pull/5107 > > I don't believe it's broken. (In reply to Joakim Erdfelt from comment #1) > > The ECA validation check still seems broken. > > > > The error mentions "Anonymous", but none of the commits from the user has > > that word. > > "Anonymous" usually means that the ECA validation service was unable to link > a contribution with an Eclipse Account. One of the other committers on the Eclipse Jetty project has noticed that the "Signed-off-by:" footer is not the first footer and does not contain an empty line before it. Could this be the problem causing the PR to fail ECA validation? (In reply to Joakim Erdfelt from comment #5) > If you look at the PR linked, you'll see several screenshots from the user > with > the output of their accounts.eclipse.org web page, the email address etc is > clearly shown as `travis@cu**ty.io` same as what's in the actual commit, and > what's in the api.github.com results you linked. > > But they do not validate, either automatically, or manually. > > The user also states in > https://github.com/eclipse/jetty.project/pull/5107#issuecomment-667574293 > > That their eclipse user id is: tspencer5c1 > > Which shows their ECA is signed - > https://accounts.eclipse.org/users/tspencer5c1 It seems that the user did fix his email account in his profile a few hours ago: https://github.com/eclipse/jetty.project/pull/5144#issuecomment-673311045 Closing but feel free to re-open if you have more questions! Thanks for looking at this. Suggestion for accounts.eclipse.org ... The email address shouldn't be displayed to the logged in user in an HTML Form input field. That would prevent the auto-replace that both the browser does and what password managers do on nearly all Form fields. Just have the email addresses listed in normal (non-form) html to that logged in user. I opened https://bugs.eclipse.org/bugs/show_bug.cgi?id=566041 to request this change to accounts.eclipse.org |