Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 565526

Summary:

[win32] Comments with CJK text are not rendered when used in Java Comments.

Product:

[Eclipse Project] Platform

Reporter:

Niraj Modi <niraj.modi>

Component:

SWT

Assignee:

Niraj Modi <niraj.modi>

Status:

VERIFIED FIXED

QA Contact:

Atsushi Nakagawa <atnak>

Severity:

normal

Priority:

CC:

1520080049, alexandr.miloslavskiy, atnak, daniel_megert, drajuang, nikita, p.beauvoir, sunjava5

Version:

4.16

Target Milestone:

4.17 M3

Hardware:

OS:

Windows 10

See Also:

https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/167051
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=bd786bc001096a195a4180b432b5d23d1cfcf3a2
https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/170946
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=917a7ff0321a7b62934b4d3ea634d1c003ec9b90
https://bugs.eclipse.org/bugs/show_bug.cgi?id=579626

Whiteboard:

Bug Depends on:

536562, 562165

Bug Blocks:

Attachments:

Description	Flags
Test-case(Updated Snippet377)	none
Another problem fixed	none

Description Niraj Modi

2020-07-24 11:13:21 EDT

This bug is for addressing part 2 of bug 536562, problem reported:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=536562#c111

This bug is for investigating if Ligature support on Windows(bug 562165) and CJK text can be used together.

Comment 1 Niraj Modi

2020-07-24 11:19:26 EDT

Created attachment 283694 [details]
Test-case(Updated Snippet377)

Comment 2 Eclipse Genie

2020-07-30 04:17:35 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/167051

Comment 3 Niraj Modi

2020-07-30 06:05:30 EDT

(In reply to Eclipse Genie from comment #2)
> New Gerrit change created:
> https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/167051

Above patch fixes the issue but is work-in-progress.

Comment 4 Eclipse Genie

2020-08-17 05:58:52 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/167051 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=bd786bc001096a195a4180b432b5d23d1cfcf3a2

Comment 5 Niraj Modi

2020-08-17 10:57:53 EDT

(In reply to Eclipse Genie from comment #4)
> Gerrit change
> https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/167051 was
> merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=bd786bc001096a195a4180b432b5d23d1cfcf3a2

Thanks Atsushi for the review, resolving now.

Comment 6 Niraj Modi

2020-08-19 05:22:51 EDT

Verified in Build id: I20200818-1800 on Win10.

Comment 7 Eclipse Genie

2020-10-19 10:51:36 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/170946

Comment 8 Alexandr Miloslavskiy

2020-10-19 10:53:38 EDT

Created attachment 284511 [details]
Another problem fixed

Today a customer of ours reported a problem with space widths. To my surprise, it turns out but it's also fixed by this Bug! Perfect, less work for me!

I have submitted another test snippet, because the problem is seemingly unrelated to current Bug description.

Comment 9 Eclipse Genie

2020-10-19 11:04:50 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/170946 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=917a7ff0321a7b62934b4d3ea634d1c003ec9b90

Comment 10 Phil Beauvoir

2022-04-08 05:04:18 EDT

Please see Bug #579626 for possible regression.