Bug 565405

Comment 1 Laurent Redor 2020-07-21 12:52:05 EDT

Several changes have been done in Eclipse FilteredTree class. The changes in FilteredTree are here since long time but not detected
before.

To be compatible from Eclipse Photon to Eclipse 202009 (canary) we can
not simply duplicate classes from current Eclipse 202009 (as it was done
before for Eclipse Juno to benefit in QuickOutlineControl, of new
features not available in Juno (bugzilla 460712 and commit 302d195d
[1]). Indeed, the delete button of the search field depends on specific
OS implementation, especially Text class for Windows that has been
adapted for that recently ("Bug 293230 - Support SWT.ICON_SEARCH and
SWT.ICON_CANCEL for native find/filter/search box for Windows 7 /
Windows 10").

In a first time, we simply copy the deleted message and uses it in our own
copies of FilteredTree.

We can switch to the new "implementation" as soon as the lower
supported version will be 201909.

[1] https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=302d195dac44967e5875fc174d43a331ad1f16fe

Comment 2 Laurent Redor 2020-07-21 12:52:23 EDT

Steps to validate:
* Activate the "Modeling" perspective
* Import projects from "samples.zip"
* In the "Model Explorer" view:
    * Expand "Sample1" project
    * Expand "Sample2" project
* In the search field of the "Model Explorer" view:
    * Write "Class"
	* Expected: 4 classes are visible (in their respective tree)
	* Complete with "C1"
	* Expected: 2 classes are visible (in their respective tree): ClassC1 and ClassC11
* Click on the erase button of the search field of the "Model Explorer" view.
* Expected: The label "ClassC1" is delected and all the elements are visible.
* Open "/Sample1/My.odesign" file
* Click on "Crtl+O"
* In the search field of the popup:
    * Write "*Diag"
	* Expected: 2 diagram descriptions are visible
	* Complete with "2"
	* Expected: 1 diagram description is visible
* Click on the erase button of the search field of the popup.
* Expected: The label "*Diag2" is delected and all the elements are visible.
* Double click on "/Sample1/representations.aird"
* Expected: The aird editor is opened.
* Under the "Models" section
* In the search field of the "Model Explorer" view:
    * Write "Class"
	* Expected: 2 classes are visible
	* Complete with "C1"
	* Expected: 1 class is visible: ClassC1

Comment 3 Laurent Redor 2020-07-21 12:52:44 EDT

Created attachment 283667 [details]
samples.zip

Comment 4 Eclipse Genie 2020-07-21 12:55:19 EDT

New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/166611

Comment 5 Laurent Redor 2020-07-21 12:56:02 EDT

The above gerrit must be reviewed/validated with both "Photon" and "Canary" target platforms.

Comment 6 Eclipse Genie 2020-07-22 04:53:47 EDT

Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/166611 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=f31dfb47a057740c32b9127b7f3c3f49e6c5c190

Comment 7 Eclipse Genie 2020-08-21 09:39:03 EDT

New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/168070

Comment 8 Eclipse Genie 2020-08-31 05:40:32 EDT

Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/168070 was merged to [v6.3.x].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=7da398ada072966ed0b74b27477e90a713b8ef21

Comment 9 Julien Dupont 2020-10-08 10:57:01 EDT

Validated with version Sirius 6.4.0.202010071648

Comment 10 Pierre-Charles David 2020-12-04 04:23:18 EST

Available in Sirius 6.4.0, see https://download.eclipse.org/sirius/updates/releases/6.4.0/ for details.