Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 565317

Summary:

External install button has low resolution

Product:

Community

Reporter:

Pierre-Yves Bigourdan <pyvesdev>

Component:

Marketplace

Assignee:

Eric Poirier <eric.poirier>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

aobuchow, chris.guindon, nobody, tellastory73

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

Windows 10

Whiteboard:

Attachments:

Description	Flags
Low resolution external install button	none
Updated Install Button	none
Button in Readme	none

Description Pierre-Yves Bigourdan

2020-07-18 04:41:58 EDT

Created attachment 283635 [details]
Low resolution external install button

This bug was first reported by Ingo Mohr on GitHub: https://github.com/AObuchow/Eclipse-Spectrum-Theme/issues/96

It's quite common nowadays to include the marketplace "external install button" in READMEs and other similar places. Unfortunately, the icon has a low resolution, and does not look good higher resolution displays.

Could the icon please be updated?

Comment 1 Christopher Guindon

2020-07-20 09:44:32 EDT

Christie, 

I am thinking we need a svg of our external install button. Can you help us create that?

Comment 2 Nobody - feel free to take it

2020-07-20 09:51:24 EDT

+1 I will add it here shortly.

Comment 3 Nobody - feel free to take it

2020-07-20 11:00:31 EDT

Created attachment 283648 [details]
Updated Install Button

Comment 4 Eric Poirier

2020-08-14 13:32:41 EDT

The high resolution button is now on the production website.

Let me know if there's anything else.

Thanks.

Comment 5 Pierre-Yves Bigourdan

2020-08-15 10:47:55 EDT

Created attachment 283879 [details]
Button in Readme

Thanks for resolving! However, I've just tried pasting the HTML obtained via the "External Install Button" tab On a GitHub readme, the button is giant. It looks like the width style is being ignored.

Comment 6 Eric Poirier

2020-08-17 11:18:54 EDT

(In reply to Pierre-Yves B. from comment #5)
> Created attachment 283879 [details]
> Button in Readme
> 
> Thanks for resolving! However, I've just tried pasting the HTML obtained via
> the "External Install Button" tab On a GitHub readme, the button is giant.
> It looks like the width style is being ignored.

Hi Pierre-Yves,

Thanks for pointing this out, I really thought that the svg would resize with the width parameter but I updated the size of the svg. If you do a SHIFT + R on the following page, you will see the updated button.

https://marketplace.eclipse.org/sites/all/themes/solstice/public/images/marketplace/btn-install.svg

Comment 7 Pierre-Yves Bigourdan

2020-08-23 13:01:18 EDT

I can confirm that it displays as expected now! For example, I've updated the following README: https://github.com/PyvesB/eclipse-solargraph

Thanks!