Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 565208

Summary:	Removal disposal of Colors
Product:	[Eclipse Project] Platform	Reporter:	Jonah Graham <jonah>
Component:	IDE	Assignee:	Jonah Graham <jonah>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	jonah, Lars.Vogel
Version:	4.17
Target Milestone:	4.17 M3
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/162999 https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166270 https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166271 https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/166272 https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/166274 https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/166276 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=8a33432ed54d413c8e53b34c66355028dbf08fa9 https://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=26bc9518ecf7c948c94034f93b369730ce24ee73 https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166577 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2cad088ee37df98a0caed5e24593406f797ea416 https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/166703 https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166705 https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/166706 https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/166708 https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166709 https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=eb65eca6e06e5eef7b126a07fa8319dc46e0bd66 https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=1a769f8e63ced7e4be1b83123d4cedac88464a5c https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=07d567a01075294ac69afaea8c92222cbebbcb4e https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/166725 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=728609b6317eb098445386b86725a9b498e57aeb https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=47e180147c7e6c0d83f35c54552d844029295541 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=9f4c2d7e7a295991c2af9db3406eea7dd360b099 https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=961c1d1d50f0bd73b5dc3f2e5b37042c63b2ce32 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=ba67eabbf1207ad025db6d9e4dbd74e95cbad904 https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/167334 https://git.eclipse.org/r/c/platform/eclipse.platform.ua/+/167335 https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/167336 https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/167337 https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=94ce09169c1c120c1c67412a581aef0c8ec6187b https://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=ca3cfcf16f71fe7397962afa04612854f704089b https://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/commit/?id=d05c3aad480f17cf176ec365a10644c2985c297c https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=063c1109b1b05c247db1e330a69f90b0bdd5f8ca https://git.eclipse.org/r/c/platform/eclipse.platform.ua/+/167376 https://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=44bca157e7413eef734fab14561e6e5ddbc438ee https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d6f6d299c7e1a8ba16a2693b9b3345c247b881fa https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/167684 https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/167685 https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/167686 https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/167689 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=07b18ab8c1a59aa7fddc2a1adacf964ab9df3df0 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=a42e981cab9c457595e4ac098ab9508d5df25e55 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=6ac212a98ac758c20742e42a3e525f0bad4cfce9 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=0381397e333dfda624b113a1720b86531eaf29ad https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=17c9f5f5a8e007248fbbedd85a2a3803b29e8b14
Whiteboard:
Bug Depends on:
Bug Blocks:	563542

Description Jonah Graham

2020-07-14 09:00:27 EDT

As we are now recommending to use non-Device/disposal Colors the SWT examples and snippets should be updated.

Comment 1 Jonah Graham

2020-07-14 09:05:43 EDT

I wrote a bit of this as a WIP (https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/162999) - before I proceed with finishing it up, I would appreciate an SWT committer to indicate that this is a useful thing to do.

Note the WIP was not limited to just the examples/snippets. It also included changes in core SWT and tests. Please comment on whether cleaning up that is desired too.

Comment 2 Eclipse Genie

2020-07-14 09:30:03 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166270

Comment 3 Eclipse Genie

2020-07-14 09:41:33 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166271

Comment 4 Eclipse Genie

2020-07-14 09:41:37 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/166272

Comment 5 Eclipse Genie

2020-07-14 09:53:25 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/166274

Comment 6 Eclipse Genie

2020-07-14 10:15:33 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/166276

Comment 7 Eclipse Genie

2020-07-17 10:13:39 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166271 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=8a33432ed54d413c8e53b34c66355028dbf08fa9

Comment 8 Eclipse Genie

2020-07-17 12:33:58 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/166276 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=26bc9518ecf7c948c94034f93b369730ce24ee73

Comment 9 Eclipse Genie

2020-07-21 05:13:55 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166577

Comment 10 Eclipse Genie

2020-07-22 03:51:23 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166577 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2cad088ee37df98a0caed5e24593406f797ea416

Comment 11 Eclipse Genie

2020-07-23 06:14:59 EDT

New Gerrit change created: https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/166703

Comment 12 Eclipse Genie

2020-07-23 06:37:30 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166705

Comment 13 Eclipse Genie

2020-07-23 06:39:44 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/166706

Comment 14 Eclipse Genie

2020-07-23 07:09:50 EDT

New Gerrit change created: https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/166708

Comment 15 Eclipse Genie

2020-07-23 07:10:34 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166709

Comment 16 Eclipse Genie

2020-07-23 08:29:04 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/166706 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=eb65eca6e06e5eef7b126a07fa8319dc46e0bd66

Comment 17 Eclipse Genie

2020-07-23 09:23:58 EDT

Gerrit change https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/166703 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=1a769f8e63ced7e4be1b83123d4cedac88464a5c

Comment 18 Eclipse Genie

2020-07-23 09:24:06 EDT

Gerrit change https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/166708 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=07d567a01075294ac69afaea8c92222cbebbcb4e

Comment 19 Eclipse Genie

2020-07-23 09:40:48 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/166725

Comment 20 Eclipse Genie

2020-07-23 16:22:23 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166709 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=728609b6317eb098445386b86725a9b498e57aeb

Comment 21 Eclipse Genie

2020-07-23 17:16:27 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166705 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=47e180147c7e6c0d83f35c54552d844029295541

Comment 22 Eclipse Genie

2020-07-24 03:24:37 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/166725 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=9f4c2d7e7a295991c2af9db3406eea7dd360b099

Comment 23 Eclipse Genie

2020-07-31 06:13:00 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/166272 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=961c1d1d50f0bd73b5dc3f2e5b37042c63b2ce32

Comment 24 Eclipse Genie

2020-08-05 13:59:25 EDT

Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166270 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=ba67eabbf1207ad025db6d9e4dbd74e95cbad904

Comment 25 Eclipse Genie

2020-08-06 04:00:56 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/167334

Comment 26 Eclipse Genie

2020-08-06 04:08:22 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ua/+/167335

Comment 27 Eclipse Genie

2020-08-06 04:10:33 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/167336

Comment 28 Eclipse Genie

2020-08-06 04:13:45 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/167337

Comment 29 Eclipse Genie

2020-08-06 04:36:48 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/167336 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=94ce09169c1c120c1c67412a581aef0c8ec6187b

Comment 30 Eclipse Genie

2020-08-06 04:37:10 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ua/+/167335 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=ca3cfcf16f71fe7397962afa04612854f704089b

Comment 31 Eclipse Genie

2020-08-06 17:00:19 EDT

Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/166274 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/commit/?id=d05c3aad480f17cf176ec365a10644c2985c297c

Comment 32 Eclipse Genie

2020-08-07 02:30:41 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/167334 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=063c1109b1b05c247db1e330a69f90b0bdd5f8ca

Comment 33 Eclipse Genie

2020-08-07 02:35:08 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ua/+/167376

Comment 34 Eclipse Genie

2020-08-07 02:47:55 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ua/+/167376 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=44bca157e7413eef734fab14561e6e5ddbc438ee

Comment 35 Eclipse Genie

2020-08-07 04:58:53 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/167337 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d6f6d299c7e1a8ba16a2693b9b3345c247b881fa

Comment 36 Eclipse Genie

2020-08-14 03:26:51 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/167684

Comment 37 Eclipse Genie

2020-08-14 03:29:24 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/167685

Comment 38 Eclipse Genie

2020-08-14 03:29:45 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/167686

Comment 39 Eclipse Genie

2020-08-14 03:37:37 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/167689

Comment 40 Eclipse Genie

2020-08-14 04:54:50 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/162999 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=07b18ab8c1a59aa7fddc2a1adacf964ab9df3df0

Comment 41 Eclipse Genie

2020-08-14 04:55:03 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/167685 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=a42e981cab9c457595e4ac098ab9508d5df25e55

Comment 42 Eclipse Genie

2020-08-14 04:55:15 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/167686 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=6ac212a98ac758c20742e42a3e525f0bad4cfce9

Comment 43 Eclipse Genie

2020-08-16 02:15:37 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/167684 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=0381397e333dfda624b113a1720b86531eaf29ad

Comment 44 Eclipse Genie

2020-08-16 02:17:49 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/167689 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=17c9f5f5a8e007248fbbedd85a2a3803b29e8b14

Comment 45 Lars Vogel

2020-08-18 11:18:17 EDT

Thanks, Jonah for starting this work. For more Color.disposal removals we do not need a bug, as these count a cleanups so I close this bug as it already contains tons of commits.