Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 564825

Summary: Download CEF binary on SWT build machines
Product: Community Reporter: Lakshmi P Shanmugam <lshanmug>
Component: CI-JenkinsAssignee: CI Admin Inbox <ci.admin-inbox>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: frederic.gurr, guillez, mikael.barbero, sravankumarl, webmaster
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=564827
https://bugs.eclipse.org/bugs/show_bug.cgi?id=564826
Whiteboard:
Bug Depends on:    
Bug Blocks: 549585    

Description Lakshmi P Shanmugam CLA 2020-07-01 05:47:24 EDT
For Chromium browser support (Bug 405031), we need the CEF headers to be available on the SWT Windows and Mac build machines.

Can you please download and extract the CEF minimal distributions on the respective machines:

1. Windows agent - windows-server-2016-1
download link - http://opensource.spotify.com/cefbuilds/cef_binary_3.3071.1649.g98725e6_windows32_minimal.tar.bz2

2. Mac agent - b9h15-macos10.12
download link - http://opensource.spotify.com/cefbuilds/cef_binary_3.3071.1649.g98725e6_macosx64_minimal.tar.bz2

We have a 3rd party CQ to use the CEF binaries at runtime - https://dev.eclipse.org/ipzilla/show_bug.cgi?id=7073. Do I need to create a new CQ for using CEF headers at buildtime?
Comment 1 Lakshmi P Shanmugam CLA 2020-07-01 06:08:07 EDT
Opened Bug 564827, request to install Rust on the machines.
Comment 2 Mikaël Barbero CLA 2020-07-01 08:47:21 EDT
(In reply to Lakshmi Shanmugam from comment #0)
> For Chromium browser support (Bug 405031), we need the CEF headers to be
> available on the SWT Windows and Mac build machines.
> 
> Can you please download and extract the CEF minimal distributions on the
> respective machines:

Where do you want those headers to be put?
 
> We have a 3rd party CQ to use the CEF binaries at runtime -
> https://dev.eclipse.org/ipzilla/show_bug.cgi?id=7073. Do I need to create a
> new CQ for using CEF headers at buildtime?

I don't think so.
Comment 3 Guillermo Zunino CLA 2020-07-01 22:15:46 EDT
This is currently coded in ant, in the getCef target.

I add the link to the code here, in case it's useful if this is reimplemented in other build scripts. 
See the destination path of the untar task. That's where the rust build will look for the cef headers and bins for linking. Please note that the root folder of the .tar is cut.

https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/159486/9/bundles/org.eclipse.swt.browser.chromium/buildChromium.xml#34
Comment 4 Lakshmi P Shanmugam CLA 2020-07-02 03:27:24 EDT
(In reply to Guillermo Zunino from comment #3)
> This is currently coded in ant, in the getCef target.
> 
> I add the link to the code here, in case it's useful if this is
> reimplemented in other build scripts. 
> See the destination path of the untar task. That's where the rust build will
> look for the cef headers and bins for linking. Please note that the root
> folder of the .tar is cut.
> 
> https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/159486/9/bundles/
> org.eclipse.swt.browser.chromium/buildChromium.xml#34

Thanks for the link, Guillermo!

The downloads are about 250MB for all platforms together. I think instead of downloading them every time there is a native build, it's better to keep them some place on the build machine. We can copy/extract to the destination location before the build, in the build job.
Comment 5 Lakshmi P Shanmugam CLA 2020-07-02 03:31:21 EDT
(In reply to Mikaël Barbero from comment #2)
> (In reply to Lakshmi Shanmugam from comment #0)
> > For Chromium browser support (Bug 405031), we need the CEF headers to be
> > available on the SWT Windows and Mac build machines.
> > 
> > Can you please download and extract the CEF minimal distributions on the
> > respective machines:
> 
> Where do you want those headers to be put?

Please put the downloaded zips in someplace from where we can copy and extract it during the build from the Windows and Mac build machines.
Comment 6 Lakshmi P Shanmugam CLA 2020-07-13 08:44:56 EDT
(In reply to Lakshmi Shanmugam from comment #5)
> (In reply to Mikaël Barbero from comment #2)
> > (In reply to Lakshmi Shanmugam from comment #0)
> > > For Chromium browser support (Bug 405031), we need the CEF headers to be
> > > available on the SWT Windows and Mac build machines.
> > > 
> > > Can you please download and extract the CEF minimal distributions on the
> > > respective machines:
> > 
> > Where do you want those headers to be put?
> 
> Please put the downloaded zips in someplace from where we can copy and
> extract it during the build from the Windows and Mac build machines.

Ping!
Comment 7 Frederic Gurr CLA 2020-07-14 08:26:38 EDT
1. Windows agent - windows-server-2016-1
Path to cef binary: C:\Users\genie_releng\cef
2. Mac agent - b9h15-macos10.12
Path to cef binary: /Users/genie.releng/cef

In both cases the directory contains the extracted files and the .tar.bz2 file.
Comment 8 Lakshmi P Shanmugam CLA 2020-07-15 07:26:30 EDT
Thank you!
Comment 9 Lakshmi P Shanmugam CLA 2020-07-17 02:38:08 EDT
(In reply to Lakshmi Shanmugam from comment #0)
> For Chromium browser support (Bug 405031), we need the CEF headers to be
> available on the SWT Windows and Mac build machines.
> 
> Can you please download and extract the CEF minimal distributions on the
> respective machines:
> 
> 1. Windows agent - windows-server-2016-1
> download link -
> http://opensource.spotify.com/cefbuilds/cef_binary_3.3071.1649.
> g98725e6_windows32_minimal.tar.bz2
>

The windows download link points to the 32bit build. We need the 64bit build from http://opensource.spotify.com/cefbuilds/cef_binary_3.3071.1649.g98725e6_windows64_minimal.tar.bz2

Can you please remove the 32 bit Windows build, and download and extract this build? Sorry about this!
Comment 10 Frederic Gurr CLA 2020-07-17 04:04:27 EDT
Done.
Comment 11 Mikaël Barbero CLA 2020-07-27 03:57:10 EDT
Closing.