Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 564763

Summary:	Mark TargetPlatform::createPlatformConfiguration for removal
Product:	[Eclipse Project] PDE	Reporter:	Julian Honnen <julian.honnen>
Component:	Doc	Assignee:	Julian Honnen <julian.honnen>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	alex.blewitt, daniel_megert, Lars.Vogel
Version:	4.17	Flags:	Lars.Vogel: pmc_approved+
Target Milestone:	4.17 M1
Hardware:	PC
OS:	Windows 10
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=527378 https://git.eclipse.org/r/c/platform/eclipse.platform.common/+/165899 https://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=56fddd55f831b4195cc5a0f93f17924de55bceca
Whiteboard:

Description Julian Honnen

2020-06-30 02:47:15 EDT

org.eclipse.pde.core.plugin.TargetPlatform.createPlatformConfiguration(File, IPluginModelBase[], IPluginModelBase)

supports generation of platform configuration files for the obsolete update.configurator and has been deprecated since 2017.

It should be marked for removal.

Comment 1 Alex Blewitt

2020-07-01 04:42:36 EDT Comment hidden (obsolete)

https://download.eclipse.org/eclipse/downloads/drops4/I20200630-1800/testresults/html/org.eclipse.pde.ui.tests_ep417I-unit-win32-java11_win32.win32.x86_64_11.html

java.lang.AssertionError 
at org.junit.Assert.fail(Assert.java:87) 
at org.junit.Assert.assertTrue(Assert.java:42) 
at org.junit.Assert.assertTrue(Assert.java:53) 
at org.eclipse.pde.ui.tests.target.TargetPlatformTests.checkPlatformXML(TargetPlatformTests.java:90) 
at org.eclipse.pde.ui.tests.target.TargetPlatformTests.testCreatePlatformConfigurationSingle(TargetPlatformTests.java:61)

The same test does not appear to fail on Linux or macOS platforms.

Comment 2 Alex Blewitt

2020-07-01 04:42:58 EDT Comment hidden (obsolete)

(In reply to Alex Blewitt from comment #1)
> https://download.eclipse.org/eclipse/downloads/drops4/I20200630-1800/
> testresults/html/org.eclipse.pde.ui.tests_ep417I-unit-win32-java11_win32.
> win32.x86_64_11.html
> 
> java.lang.AssertionError 
> at org.junit.Assert.fail(Assert.java:87) 
> at org.junit.Assert.assertTrue(Assert.java:42) 
> at org.junit.Assert.assertTrue(Assert.java:53) 
> at
> org.eclipse.pde.ui.tests.target.TargetPlatformTests.
> checkPlatformXML(TargetPlatformTests.java:90) 
> at
> org.eclipse.pde.ui.tests.target.TargetPlatformTests.
> testCreatePlatformConfigurationSingle(TargetPlatformTests.java:61)
> 
> The same test does not appear to fail on Linux or macOS platforms.

Sorry, wrong bug.

Comment 3 Lars Vogel

2020-07-06 07:45:40 EDT

Julian, can you take this?

Comment 4 Eclipse Genie

2020-07-06 09:17:32 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.common/+/165899

Comment 5 Eclipse Genie

2020-07-06 09:17:54 EDT

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.common/+/165899 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=56fddd55f831b4195cc5a0f93f17924de55bceca