Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 564420

Summary:	[Passage] API revision \| conditions \| move HC condition miner to new interfaces
Product:	[Technology] Passage	Reporter:	Elena Parovyshnaia <elena.parovyshnaya>
Component:	API	Assignee:	Elena Parovyshnaia <elena.parovyshnaya>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	0.9.0
Target Milestone:	1.0.0
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:	564566
Bug Blocks:	564326

Description Elena Parovyshnaia

2020-06-18 08:31:17 EDT

In scope of 
 564326 [Passage] API revision | redesign work with licensing conditions 
new condition describig and mining interfaces are invited. 

We need then restructure/rework current implementations for new interfaces. 

HC condition miner (`lic.hc`) bundle mines conditions through http. This functionality must be ported to new interfaces. 
Besides, implementation has several design (sever lack of srp, low cohesion) and cosmetic (naming) issues and looks untestable. 

In the scope of this task
 - `HcConditionMiner` functionality  must be ported to new interfaces 
 - code quality should be improved
 - tests must appear: unit tests for emulated server behaviour

Comment 1 Elena Parovyshnaia

2020-06-21 06:53:32 EDT

Pull ConditionTransport notion to the new interfaces ground
---------------------------------------------------------
PR#1 https://github.com/eclipse-passage/passage/pull/257
  - invite ConditionMiningException
  - port ConditionTransport to new Condition interfaces

PR#2 https://github.com/eclipse-passage/passage/pull/259
  - contract test for ConditionTransport

PR#3 https://github.com/eclipse-passage/passage/pull/260
  - make ConditionTransport interface a Service identified with ContentType
  - supply dedicated registry interface


PR#4 https://github.com/eclipse-passage/passage/pull/261
  - implement ConditionTransport service for application/json content
type

PR#5 https://github.com/eclipse-passage/passage/pull/262
  - tests for json condtion transport
---------------------------------------------------------

Comment 2 Elena Parovyshnaia

2020-06-27 12:58:29 EDT

PR#6 https://github.com/eclipse-passage/passage/pull/268
  - general settings reading service
  - licensing server coordinates

PR#7 https://github.com/eclipse-passage/passage/pull/269
  - licensing server coordinates detection service

Comment 3 Elena Parovyshnaia

2020-07-01 03:57:04 EDT

PR#8 https://github.com/eclipse-passage/passage/pull/273
  - RemoteConditionsRequest


PR#9 https://github.com/eclipse-passage/passage/pull/274
  - documenting the solution and deprecating existing `HcConditionMiner`

Comment 4 Elena Parovyshnaia

2020-07-01 06:21:22 EDT

- `lic.hc` implementation of reworked: `remote package` contains new interfaces, `impl` package implements the remote condition mining on the base of `java.net` package facilities. `apache.http` dependency becomes obsolete.

- related public string constants from `lic.net` are deprecated in the favor of remastered functionality built upon `NamedData` approach

 - related static utilities are also reworked and deprecated with explanatory notes.