Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 564416

Summary:	Use lambdas and method references cleanup on JDT UI code
Product:	[Eclipse Project] JDT	Reporter:	Lars Vogel <Lars.Vogel>
Component:	UI	Assignee:	Lars Vogel <Lars.Vogel>
Status:	VERIFIED FIXED	QA Contact:	Jeff Johnston <jjohnstn>
Severity:	normal
Priority:	P3	CC:	carsten.hammer, fabrice.tiercelin, jjohnstn, Lars.Vogel, rgrunber
Version:	4.14
Target Milestone:	4.17 M3
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/165139 https://git.eclipse.org/r/165140 https://git.eclipse.org/r/165141 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=0d81c3e4183d632001b02d53b246dc65b13894cd https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/165139 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=27a3473265506eccf7a61df662e760ce772d54d2 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=74b642f6d4726cd11eded989399baab9cc42abe5 https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166250 https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166251 https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166252 https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166253 https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166254 https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166255 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=91f79ecb04d2433516a24ff7f0fb44f76afb7a1a https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=3f24a155a5e7d5dbe23385c36898c9ca974de07f https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=064120cc1d55f304d32e75b254d6615f80b74732 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=66848a3268695de216ab63abdab756024097ef19 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=97a8a94ee42c4b1f1f62bf0bdaaf22b73a7caa90 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=72fb4f4067a7501238b890f24ea476e3b0fdc2ea https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166497 https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166498 https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166499 https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166500 https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166501 https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166503 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=23b866d8e1f8dd42115cc8952524c0fca8e34974 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=9c3704c1e206878551337f43f2c2d6bc73503dda https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=97be82054ea0d2834f08f5a233139a5560982c01 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=b240f90418524ec46192b5ac0a08652510a47277 https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166746 https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166747 https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166748 https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166749 https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166750 https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166751 https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166752 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=a3c7f2e97f23585437ed638fbcb93c036a33f212 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=d5e3496d72efe3dea4d40129c3b9f5b32f106d2e https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=db3adc0ef3facc93d80a2ddee38dec319b2bdd9b https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=2ee3d0485baeef6049a44be7a583dacba98fd30a https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=78af2a7127a988268170d0b3399d67e011e5ae64 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=1aaf7567215933b00da6931ec9b505eb5f280d1a https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166977 https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166978 https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166979 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=315e955d2eab8e4b28cc8c6078f40d0fb3eb1e68 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=e0b8c4a05fdb3ca1ade9a97ea71394fb3f477ddd https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=eb5b350c3d8526df1252f109ae3ea7837c797622 https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/167325 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=1ccbb768ebecd93b8e660851c1c0a852d3d9a351
Whiteboard:
Bug Depends on:
Bug Blocks:	563542

Description Lars Vogel

2020-06-18 07:42:59 EDT

I think it would be nice if JDT UI uses its own cleanup to move its code base to lambdas and method references.

Comment 1 Eclipse Genie

2020-06-18 07:45:23 EDT

New Gerrit change created: https://git.eclipse.org/r/165139

Comment 2 Eclipse Genie

2020-06-18 07:46:07 EDT

New Gerrit change created: https://git.eclipse.org/r/165140

Comment 3 Eclipse Genie

2020-06-18 07:46:25 EDT

New Gerrit change created: https://git.eclipse.org/r/165141

Comment 4 Noopur Gupta

2020-06-19 05:12:58 EDT

Thanks for the patches, Lars.

A note for the reviewers: please review each conversion keeping its code context in mind as the clean up action can sometimes lead to changes in the semantics causing hidden bugs.

Comment 5 Eclipse Genie

2020-06-26 14:41:39 EDT

Gerrit change https://git.eclipse.org/r/165140 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=0d81c3e4183d632001b02d53b246dc65b13894cd

Comment 6 Eclipse Genie

2020-07-11 09:12:56 EDT

Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/165139 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=27a3473265506eccf7a61df662e760ce772d54d2

Comment 7 Eclipse Genie

2020-07-11 09:32:53 EDT

Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/165141 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=74b642f6d4726cd11eded989399baab9cc42abe5

Comment 8 Jeff Johnston

2020-07-11 13:11:34 EDT

Hi Lars, can this be considered resolved now?

Comment 9 Lars Vogel

2020-07-14 04:17:02 EDT

(In reply to Jeff Johnston from comment #8)
> Hi Lars, can this be considered resolved now?

Not yet.

Comment 10 Eclipse Genie

2020-07-14 04:20:23 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166250

Comment 11 Eclipse Genie

2020-07-14 04:20:36 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166251

Comment 12 Eclipse Genie

2020-07-14 04:22:54 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166252

Comment 13 Eclipse Genie

2020-07-14 04:26:09 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166253

Comment 14 Eclipse Genie

2020-07-14 04:27:22 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166254

Comment 15 Eclipse Genie

2020-07-14 04:27:35 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166255

Comment 16 Eclipse Genie

2020-07-14 16:26:37 EDT

Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166250 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=91f79ecb04d2433516a24ff7f0fb44f76afb7a1a

Comment 17 Eclipse Genie

2020-07-14 18:20:25 EDT

Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166251 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=3f24a155a5e7d5dbe23385c36898c9ca974de07f

Comment 18 Eclipse Genie

2020-07-14 20:11:13 EDT

Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166254 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=064120cc1d55f304d32e75b254d6615f80b74732

Comment 19 Eclipse Genie

2020-07-14 20:23:28 EDT

Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166253 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=66848a3268695de216ab63abdab756024097ef19

Comment 20 Eclipse Genie

2020-07-14 20:26:41 EDT

Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166255 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=97a8a94ee42c4b1f1f62bf0bdaaf22b73a7caa90

Comment 21 Eclipse Genie

2020-07-15 16:12:57 EDT

Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166252 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=72fb4f4067a7501238b890f24ea476e3b0fdc2ea

Comment 22 Eclipse Genie

2020-07-20 05:05:17 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166497

Comment 23 Eclipse Genie

2020-07-20 05:06:00 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166498

Comment 24 Eclipse Genie

2020-07-20 05:06:14 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166499

Comment 25 Eclipse Genie

2020-07-20 05:08:27 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166500

Comment 26 Eclipse Genie

2020-07-20 05:09:40 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166501

Comment 27 Eclipse Genie

2020-07-20 05:22:57 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166503

Comment 28 Eclipse Genie

2020-07-23 14:03:57 EDT

Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166497 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=23b866d8e1f8dd42115cc8952524c0fca8e34974

Comment 29 Eclipse Genie

2020-07-23 14:25:47 EDT

Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166501 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=9c3704c1e206878551337f43f2c2d6bc73503dda

Comment 30 Eclipse Genie

2020-07-23 14:26:41 EDT

Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166503 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=97be82054ea0d2834f08f5a233139a5560982c01

Comment 31 Eclipse Genie

2020-07-23 14:48:56 EDT

Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166500 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=b240f90418524ec46192b5ac0a08652510a47277

Comment 32 Eclipse Genie

2020-07-23 15:32:31 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166746

Comment 33 Eclipse Genie

2020-07-23 15:32:44 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166747

Comment 34 Eclipse Genie

2020-07-23 15:33:27 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166748

Comment 35 Eclipse Genie

2020-07-23 15:33:40 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166749

Comment 36 Eclipse Genie

2020-07-23 15:34:04 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166750

Comment 37 Eclipse Genie

2020-07-23 15:34:17 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166751

Comment 38 Eclipse Genie

2020-07-23 15:34:40 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166752

Comment 39 Eclipse Genie

2020-07-24 11:03:09 EDT

Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166746 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=a3c7f2e97f23585437ed638fbcb93c036a33f212

Comment 40 Eclipse Genie

2020-07-24 18:53:25 EDT

Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166751 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=d5e3496d72efe3dea4d40129c3b9f5b32f106d2e

Comment 41 Eclipse Genie

2020-07-24 22:50:02 EDT

Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166752 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=db3adc0ef3facc93d80a2ddee38dec319b2bdd9b

Comment 42 Eclipse Genie

2020-07-24 23:07:17 EDT

Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166747 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=2ee3d0485baeef6049a44be7a583dacba98fd30a

Comment 43 Eclipse Genie

2020-07-24 23:09:31 EDT

Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166749 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=78af2a7127a988268170d0b3399d67e011e5ae64

Comment 44 Eclipse Genie

2020-07-28 16:48:57 EDT

Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166748 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=1aaf7567215933b00da6931ec9b505eb5f280d1a

Comment 45 Eclipse Genie

2020-07-29 05:05:33 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166977

Comment 46 Eclipse Genie

2020-07-29 05:05:37 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166978

Comment 47 Eclipse Genie

2020-07-29 05:06:36 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166979

Comment 48 Eclipse Genie

2020-08-05 13:47:54 EDT

Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166977 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=315e955d2eab8e4b28cc8c6078f40d0fb3eb1e68

Comment 49 Eclipse Genie

2020-08-05 13:48:16 EDT

Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166979 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=e0b8c4a05fdb3ca1ade9a97ea71394fb3f477ddd

Comment 50 Eclipse Genie

2020-08-05 14:00:38 EDT

Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/166978 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=eb5b350c3d8526df1252f109ae3ea7837c797622

Comment 51 Eclipse Genie

2020-08-06 01:45:11 EDT

New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/167325

Comment 52 Eclipse Genie

2020-08-06 18:40:11 EDT

Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.ui/+/167325 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=1ccbb768ebecd93b8e660851c1c0a852d3d9a351

Comment 53 Lars Vogel

2020-08-07 02:51:05 EDT

Thanks, Jeff for the reviews on so many changes.

Comment 54 Jeff Johnston

2020-08-07 11:25:45 EDT

(In reply to Lars Vogel from comment #53)
> Thanks, Jeff for the reviews on so many changes.

No problem.  Thanks for going through all the code and cleaning up.

Comment 55 Jeff Johnston

2020-08-07 11:26:03 EDT

Released for 4.17M3

Comment 56 Jeff Johnston

2020-08-18 17:05:17 EDT

Verified for 4.17M3 using I20200818-0900 build