Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 564320

Summary:	[launch config] redundant refresh of Plugins tree
Product:	[Eclipse Project] PDE	Reporter:	Julian Honnen <julian.honnen>
Component:	UI	Assignee:	Julian Honnen <julian.honnen>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	4.16
Target Milestone:	4.17 M1
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/164961 https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=712f656b63c4583aa69b56416a2a7d3428ed4ad2
Whiteboard:
Bug Depends on:
Bug Blocks:	565105

Description Julian Honnen

2020-06-16 03:52:13 EDT

When selecting a launch configuration in the dialog, the plugins tree gets refreshed twice, costing some performance in large workspaces.

The first refresh is from setting input to the viewer and obviously unavoidable.

The second refresh is supposed to apply the "Only show selected" filter after the checked state has been set.

We can easily improve performance by skipping the second refresh if the filter is disabled (which it is by default).

Comment 1 Eclipse Genie

2020-06-16 03:57:17 EDT

New Gerrit change created: https://git.eclipse.org/r/164961

Comment 2 Eclipse Genie

2020-06-16 05:19:07 EDT

Gerrit change https://git.eclipse.org/r/164961 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=712f656b63c4583aa69b56416a2a7d3428ed4ad2

Comment 3 Vikas Chandra

2020-07-07 04:14:09 EDT

Julian, can you please verify the bug.

Comment 4 Julian Honnen

2020-07-07 05:18:37 EDT

verified with I20200706-2300