Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 564242

Summary: [Dark Theme] Find actions navigation does not work (ctrl + 3)
Product: [Eclipse Project] Platform Reporter: Fernando Cortes <lfcortes12>
Component: IDEAssignee: Platform-UI-Inbox <Platform-UI-Inbox>
Status: CLOSED DUPLICATE QA Contact:
Severity: normal    
Priority: P3 CC: Lars.Vogel, rolf.theunissen
Version: 4.16   
Target Milestone: ---   
Hardware: PC   
OS: Windows 10   
Whiteboard:
Bug Depends on:    
Bug Blocks: 563541    
Attachments:
Description Flags
navigationissue
none
Screencast none

Description Fernando Cortes CLA 2020-06-12 07:20:16 EDT
Created attachment 283251 [details]
navigationissue

Navigation with arrows up/down does not work in the Find Actions modal panel.

Version: 2020-06 RC1 (4.16.0RC1)
Build id: 20200604-2245
Win10
Comment 1 Fernando Cortes CLA 2020-06-12 07:26:25 EDT
I found this exception in the log doing that:


!ENTRY org.eclipse.ui 4 4 2020-06-12 06:25:14.850
!MESSAGE Conflicting handlers for org.springframework.ide.eclipse.boot.wizard.addStarersSwitchHandler: {org.springframework.ide.eclipse.boot.wizard.starters.AddStartersSwitchHandler} vs {org.springframework.ide.eclipse.boot.wizard.starters.AddStartersSwitchHandler} in: PartImpl (org.eclipse.jdt.ui.PackageExplorer) Context
!STACK 0
java.lang.IllegalStateException: Conflicting handlers: {[org.springframework.ide.eclipse.boot.wizard.starters.AddStartersSwitchHandler,  for 'org.springframework.ide.eclipse.boot.wizard.addStarersSwitchHandler',  in WorkbenchContext, active=true, sourcePriority=0, participating=true]} vs {[org.springframework.ide.eclipse.boot.wizard.starters.AddStartersSwitchHandler,  for 'org.springframework.ide.eclipse.boot.wizard.addStarersSwitchHandler',  in WorkbenchContext, active=true, sourcePriority=0, participating=true]} in: PartImpl (org.eclipse.jdt.ui.PackageExplorer) Context
	at org.eclipse.ui.internal.handlers.LegacyHandlerService$HandlerSelectionFunction.compute(LegacyHandlerService.java:145)
	at org.eclipse.e4.core.internal.contexts.ValueComputation.get(ValueComputation.java:70)
	at org.eclipse.e4.core.internal.contexts.EclipseContext.internalGet(EclipseContext.java:271)
	at org.eclipse.e4.core.internal.contexts.EclipseContext.internalGet(EclipseContext.java:282)
	at org.eclipse.e4.core.internal.contexts.EclipseContext.internalGet(EclipseContext.java:282)
	at org.eclipse.e4.core.internal.contexts.EclipseContext.internalGet(EclipseContext.java:282)
	at org.eclipse.e4.core.internal.contexts.EclipseContext.get(EclipseContext.java:237)
	at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.lookUpHandler(HandlerServiceImpl.java:103)
	at org.eclipse.e4.core.commands.internal.HandlerServiceHandler.setEnabled(HandlerServiceHandler.java:75)
	at org.eclipse.core.commands.Command.setEnabled(Command.java:856)
	at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.canExecute(HandlerServiceImpl.java:179)
	at org.eclipse.ui.internal.quickaccess.providers.CommandProvider.retrieveCommand(CommandProvider.java:102)
	at org.eclipse.ui.internal.quickaccess.providers.CommandProvider.getElements(CommandProvider.java:85)
	at org.eclipse.ui.internal.quickaccess.QuickAccessProvider.getElementsSorted(QuickAccessProvider.java:83)
	at org.eclipse.ui.internal.quickaccess.QuickAccessContents$3.runInUIThread(QuickAccessContents.java:398)
	at org.eclipse.ui.progress.UIJob.lambda$0(UIJob.java:95)
	at org.eclipse.ui.progress.UIJob$$Lambda$743.0000000000000000.run(Unknown Source)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:40)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:185)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4005)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3633)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1158)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:338)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1047)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:155)
	at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:658)
	at org.eclipse.ui.internal.Workbench$$Lambda$110.0000000000000000.run(Unknown Source)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:338)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:557)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:154)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:150)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:203)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:137)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:107)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:401)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:255)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:567)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:657)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:594)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1447)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1420)
Comment 2 Rolf Theunissen CLA 2020-06-12 07:31:21 EDT
The navigation does work in the light them, however it is broken in the dark theme. Moreover, the highlighted selection is not shown in the screenshot attached. Selection does work after activating the popup.

I don't think that that error is related.
Comment 3 Lars Vogel CLA 2020-06-12 07:38:02 EDT
Fernando, please do not cc me to platform bugs. I'm watching the queue.
Comment 4 Lars Vogel CLA 2020-06-12 07:50:10 EDT
Works for me in plain SDK, sounds to me that Springboot is defining a conflicting handler which causes the issue. Fernando, please report https://github.com/spring-projects/sts4 and link to this bug.
Comment 5 Rolf Theunissen CLA 2020-06-12 07:55:33 EDT
Doesn't work for me on Windows plain SDK on latest I-build.
Comment 6 Lars Vogel CLA 2020-06-12 08:00:51 EDT
Created attachment 283254 [details]
Screencast

Screencast on:

Eclipse SDK
Version: 2020-09 (4.17)
Build id: I20200610-1800
OS: Linux, v.5.4.0-37-generic, x86_64 / gtk 3.24.18
Java version: 1.8.0_252
Comment 7 Rolf Theunissen CLA 2020-06-12 08:07:44 EDT
Seems that the issue is the missing highlight in the dark theme on windows. By using the arrows it is possible to select an item, only you don't get any visual feedback on the selection. The selection seems also missing from the quick-fix dialog, thought there is some feedback due to colors in the text.
Comment 8 Lars Vogel CLA 2020-06-12 08:12:00 EDT
(In reply to Rolf Theunissen from comment #7)
> Seems that the issue is the missing highlight in the dark theme on windows.
> By using the arrows it is possible to select an item, only you don't get any
> visual feedback on the selection. The selection seems also missing from the
> quick-fix dialog, thought there is some feedback due to colors in the text.

In this case I think this is a dup of Bug 562043

*** This bug has been marked as a duplicate of bug 562043 ***
Comment 9 Fernando Cortes CLA 2020-06-12 09:45:36 EDT
(In reply to Lars Vogel from comment #3)
> Fernando, please do not cc me to platform bugs. I'm watching the queue.

Sorry for that :D I just added you because I follow you by twitter.
Comment 10 Lars Vogel CLA 2020-06-12 09:49:16 EDT
(In reply to Fernando Cortes from comment #9)
> Sorry for that :D I just added you because I follow you by twitter.

No, worries, but cc me to platform bugs gives me two email notifications and might give others the impression that I plan to work on a bug and therefore reduce the chance that others pick up a bug.