Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 564162

Summary:

[Win] Disabled Checkbox with set foreground color is drawn slightly left compared to an enabled one

Product:

[Eclipse Project] Platform

Reporter:

Thomas Singer <ts-swt>

Component:

SWT

Assignee:

Alexandr Miloslavskiy <alexandr.miloslavskiy>

Status:

VERIFIED FIXED

QA Contact:

Thomas Singer <ts-swt>

Severity:

normal

Priority:

CC:

alexandr.miloslavskiy, niraj.modi, ts-swt

Version:

4.17

Target Milestone:

4.17 M1

Hardware:

OS:

Windows 10

See Also:

https://git.eclipse.org/r/164714
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=408f2ffeeedb087f4a67401e55d9126c4607f709
https://bugs.eclipse.org/bugs/show_bug.cgi?id=576614

Whiteboard:

Attachments:

Description	Flags
Snippet to reproduce	none
Screenshot/animation	none

Description Thomas Singer

2020-06-10 05:32:56 EDT

Please try attached snippet (I'm using Windows 10, 4k monitor with 125% screen scaling). Clicking the button moves the disabled checkbox' text a little bit left to the enabled text.

Comment 1 Thomas Singer

2020-06-10 05:33:14 EDT

Created attachment 283212 [details]
Snippet to reproduce

Comment 2 Thomas Singer

2020-06-10 05:33:48 EDT

Created attachment 283213 [details]
Screenshot/animation

Comment 3 Thomas Singer

2020-06-10 05:35:03 EDT

I'm using the latest SWT v4936r3 (commit f5b9e6f2).

Comment 4 Eclipse Genie

2020-06-11 11:28:43 EDT

New Gerrit change created: https://git.eclipse.org/r/164714

Comment 5 Alexandr Miloslavskiy

2020-06-11 11:41:24 EDT

Thomas's snippet requires screen DPI 175% to reproduce. In my patch, I have submitted a new snippet that should reproduce the problem at any DPI.

Comment 6 Thomas Singer

2020-06-16 04:39:52 EDT

The patch fixes the problem for me. IMHO this can be merged.

Comment 7 Eclipse Genie

2020-06-16 13:04:23 EDT

Gerrit change https://git.eclipse.org/r/164714 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=408f2ffeeedb087f4a67401e55d9126c4607f709

Comment 8 Niraj Modi

2020-06-16 13:06:39 EDT

(In reply to Thomas Singer from comment #6)
> The patch fixes the problem for me. IMHO this can be merged.

(In reply to Eclipse Genie from comment #7)
> Gerrit change https://git.eclipse.org/r/164714 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=408f2ffeeedb087f4a67401e55d9126c4607f709

Thanks Alexandr/Thomas for addressing this use-case.

Comment 9 Alexandr Miloslavskiy

2020-06-17 09:22:10 EDT

Thanks for reviewing!

Comment 10 Niraj Modi

2020-07-09 01:08:14 EDT

Verified in Eclipse Build id: I20200706-2300 on Win10.