Bugzilla – Full Text Bug Listing
| Summary: | Feature request: Add splash screen to MAT | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] MAT | Reporter: | Kevin Grigorenko <kevin.grigorenko> | ||||||||||||
| Component: | GUI | Assignee: | Kevin Grigorenko <kevin.grigorenko> | ||||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||||
| Severity: | enhancement | ||||||||||||||
| Priority: | P3 | ||||||||||||||
| Version: | 1.10 | ||||||||||||||
| Target Milestone: | 1.13.0 | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | All | ||||||||||||||
| See Also: |
https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/192987 https://git.eclipse.org/c/mat/org.eclipse.mat.git/commit/?id=09ebfe5f40e454c04a51c00781fa4c4a7f9af651 |
||||||||||||||
| Whiteboard: | |||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Kevin Grigorenko
A workaround appears to be to change osgi.splashPath in configuration/conig.ini to the following to use the Eclipse splash screen: osgi.splashPath=platform\:/base/plugins/org.eclipse.platform The existing line specifies: osgi.splashPath=platform\:/base/plugins/org.eclipse.mat.ui.rcp However, there is no splash.bmp in org.eclipse.mat.ui.rcp: https://git.eclipse.org/c/mat/org.eclipse.mat.git/tree/plugins/org.eclipse.mat.ui.rcp We would need a nice image. This might give some hints as to get a Tycho/Maven build to add the splash screen option. https://github.com/jsievers/tycho-demo/tree/master/exercises/Exercise_05_Solution Created attachment 283220 [details]
MAT splash screen
I'm not very good with graphics, but attached is one attempt I made in GIMP.
Created attachment 283221 [details]
MAT splash screen GIMP source file
The splash screen image looks okay. Check the instructions that the Eclipse platform uses for building the image for some oddities about the bmp format. https://wiki.eclipse.org/Platform-releng/Updating_Branding The Eclipse logo seems to change regularly - see https://www.eclipse.org/artwork/ and the rules are here https://www.eclipse.org/legal/logo_guidelines.php MAT is an Eclipse project and so long as you haven't modified the Eclipse logo I think that's okay. It might not be the most modern image, but currently MAT is built on top of Photon, which is back level. FYI, we just use an (old) Eclipse logo in the 'about' window: org.eclipse.mat.ui.rcp/icons/eclipse_lg.gif You could also consider whether org.eclipse.mat.ui.rcp/plugin_customization.ini should to be changed to have # show progress on startup org.eclipse.ui/SHOW_PROGRESS_ON_STARTUP=true but that might not have any effect as we are based on Eclipse 4. (In reply to Andrew Johnson from comment #5) > The splash screen image looks okay. > Check the instructions that the Eclipse platform uses for building the image > for some oddities about the bmp format. > https://wiki.eclipse.org/Platform-releng/Updating_Branding > > The Eclipse logo seems to change regularly - see > https://www.eclipse.org/artwork/ and the rules are here > https://www.eclipse.org/legal/logo_guidelines.php > MAT is an Eclipse project and so long as you haven't modified the Eclipse > logo I think that's okay. > It might not be the most modern image, but currently MAT is built on top of > Photon, which is back level. > > FYI, we just use an (old) Eclipse logo in the 'about' window: > org.eclipse.mat.ui.rcp/icons/eclipse_lg.gif I took the logo image from https://eclipse.org/mat/ so I presume that's okay. Are you comfortable with this new splash screen? Should I put it up for a vote on the mailing list? This change didn't make it to 1.11.0 - so we will need to set a new target release. Created attachment 286648 [details]
New splash image
We use the splash image on an internal fork build of MAT and I recently fixed some color issues it had based on https://wiki.eclipse.org/Platform-releng/Updating_Branding#Splash_screen From GIMP, the BMP needs to be saved in 24-bit format and without color space information. New version of the image attached to the bug. One minor point - if you look at the attachment 286648 [details] on a white background it has a black border on the top, left, bottom, but not the right hand side.
That might look a bit odd on MAT start-up on a system with a light desktop background.
Created attachment 288487 [details]
New splash image
Created attachment 288488 [details]
MAT splash screen GIMP source file
(In reply to Andrew Johnson from comment #11) > One minor point - if you look at the attachment 286648 [details] on a white > background it has a black border on the top, left, bottom, but not the right > hand side. > That might look a bit odd on MAT start-up on a system with a light desktop > background. Uploaded new attempt in attachment 288487 [details] Looks good - would you like to deliver this? Do go ahead. I'm out of the office until Monday so if you need it sooner for the 1.13 release, feel free to do it; otherwise, I'll do it next week. New Gerrit change created: https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/192987 Gerrit change https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/192987 was merged to [master]. Commit: http://git.eclipse.org/c/mat/org.eclipse.mat.git/commit/?id=09ebfe5f40e454c04a51c00781fa4c4a7f9af651 I've delivered your changes - it works for me, so I hope it's good for you too. |