Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 564088

Summary: org.eclipse.tips.ide activator used to access dialog settings
Product: [Eclipse Project] Platform Reporter: Lars Vogel <Lars.Vogel>
Component: User AssistanceAssignee: Alex Blewitt <alex.blewitt>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: alex.blewitt, alexander.fedorov, Lars.Vogel, wim.jongman
Version: 4.14   
Target Milestone: 4.18 M3   
Hardware: PC   
OS: Linux   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=549929
https://git.eclipse.org/r/c/platform/eclipse.platform.ua/+/171553
https://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=056a827084d22f213d92c41eb397f24f4cf74fa1
Whiteboard:
Bug Depends on: 549929    
Bug Blocks: 566485    

Description Lars Vogel CLA 2020-06-08 11:09:32 EDT
Looks like the any reason org.eclipse.tips.ide uses an activator is to access the dialog settings.

Do we have other API for that? If yes, we could remove this activator too.
Comment 1 Lars Vogel CLA 2020-06-08 11:10:01 EDT
Usage in IDETipManager: 

return super.open(startUp, Plugin.getInstance().getDialogSettings());
Comment 2 Alexander Fedorov CLA 2020-06-09 02:42:58 EDT
DialogSetting loading/saving is one of the main reasons to still use AbstractUIPlugin for many bundles. It would be great to have a replacement that still supports lazy initialization.
Comment 3 Alex Blewitt CLA 2020-10-28 18:55:40 EDT
Maybe with the new API provided in 549929 we could replace these calls with PlatformUI.getDialogSettingsProvider()
Comment 4 Lars Vogel CLA 2020-10-29 03:07:32 EDT
(In reply to Alex Blewitt from comment #3)
> Maybe with the new API provided in 549929 we could replace these calls with
> PlatformUI.getDialogSettingsProvider()

+1
Comment 5 Eclipse Genie CLA 2020-10-31 19:29:32 EDT
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ua/+/171553
Comment 7 Lars Vogel CLA 2020-11-02 05:54:45 EST
Thanks, Alex.