Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 563873

Summary:	frequent layout() calls in LaunchConfigurationTabGroupViewer
Product:	[Eclipse Project] Platform	Reporter:	Julian Honnen <julian.honnen>
Component:	Debug	Assignee:	Julian Honnen <julian.honnen>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Lars.Vogel, sarika.sinha
Version:	4.16
Target Milestone:	4.17 M1
Hardware:	PC
OS:	Windows 10
See Also:	https://git.eclipse.org/r/164926 https://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=7a663a44380ebdfc13df2796fca835e4be1ff0b5 https://bugs.eclipse.org/bugs/show_bug.cgi?id=564457
Whiteboard:
Bug Depends on:
Bug Blocks:	563542, 564457

Description Julian Honnen

2020-06-03 04:30:39 EDT

When switching between two launch configurations I see five synchronous Composite.layout() calls triggered by showLink() and updateVisibleControls() of LaunchConfigurationTabGroupViewer.

The layout spents quite some time Tree::computeSizeInPixels which I assume is caused by the Plugin tree with >2000 bundles in my workspace.

We should switch to requestLayout() instead.

Comment 1 Eclipse Genie

2020-06-15 11:30:56 EDT

New Gerrit change created: https://git.eclipse.org/r/164926

Comment 2 Eclipse Genie

2020-06-16 01:56:54 EDT

Gerrit change https://git.eclipse.org/r/164926 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=7a663a44380ebdfc13df2796fca835e4be1ff0b5

Comment 3 Lars Vogel

2020-06-19 04:17:30 EDT

Thanks Julian, great to see you joining the quest for asynchronous layouting.

Comment 4 Sarika Sinha

2020-07-08 12:47:45 EDT

Version: 2020-09 (4.17)
Build id: I20200706-2300