Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 563547

Summary:	Evaluate why layout call in ActionBars#updateActionBars is necessary
Product:	[Eclipse Project] Platform	Reporter:	Lars Vogel <Lars.Vogel>
Component:	UI	Assignee:	Lars Vogel <Lars.Vogel>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Lars.Vogel, rolf.theunissen
Version:	4.14
Target Milestone:	4.17 M1
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/163522 https://bugs.eclipse.org/bugs/show_bug.cgi?id=483493 https://git.eclipse.org/r/163748 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c9198b29c5d55b43b22217b85fb0b415c0d14935 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f2f326c7a8c0d4712333736521c74ae7b0501cc0
Whiteboard:
Bug Depends on:
Bug Blocks:	563542

Description Lars Vogel

2020-05-25 07:19:38 EDT

Removing the call does not seem to make a differenc on Linux. Pushing a Gerrit for evaluation on other platforms.

Comment 1 Lars Vogel

2020-05-25 07:21:21 EDT

The "unstyled" area is getting visible with this change (the little black area between the buttons and the "normal" side.

Comment 2 Eclipse Genie

2020-05-25 07:22:00 EDT

New Gerrit change created: https://git.eclipse.org/r/163522

Comment 3 Rolf Theunissen

2020-05-25 08:32:55 EDT

When the model is in sync with the legacy toolbars (AFAIK they should be by now), these layout calls should be triggered by the renderers. It should be sufficient to call reconcileManagerToModel without special tricks in the updateActionBars call. If tricks are needed, there are use-cases that they are needed for direct model manipulation too.

Comment 4 Lars Vogel

2020-05-25 09:05:04 EDT

(In reply to Rolf Theunissen from comment #3)
> When the model is in sync with the legacy toolbars (AFAIK they should be by
> now), these layout calls should be triggered by the renderers. It should be
> sufficient to call reconcileManagerToModel without special tricks in the
> updateActionBars call. If tricks are needed, there are use-cases that they
> are needed for direct model manipulation too.

I suspect that this layout call is their to cover up background color issues as reported via Bug 483493.

Comment 5 Rolf Theunissen

2020-05-25 10:25:11 EDT

Might be related to Bug 546987 too

Comment 6 Eclipse Genie

2020-05-28 05:37:21 EDT

New Gerrit change created: https://git.eclipse.org/r/163748

Comment 7 Lars Vogel

2020-05-28 05:44:08 EDT

(In reply to Eclipse Genie from comment #6)
> New Gerrit change created: https://git.eclipse.org/r/163748

This removes the layout /requestLayout call, as this should not be necessary in a bug free code as Rolf explained.

So we can try this phase-wise, first move to non-blocking layout calls and check if nothing breaks and afterwards try to remove the call completely.

Comment 8 Eclipse Genie

2020-06-07 12:51:53 EDT

Gerrit change https://git.eclipse.org/r/163522 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c9198b29c5d55b43b22217b85fb0b415c0d14935

Comment 9 Eclipse Genie

2020-06-19 09:56:24 EDT

Gerrit change https://git.eclipse.org/r/163748 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f2f326c7a8c0d4712333736521c74ae7b0501cc0