Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 563537

Summary:	Remove unnecessary activator in org.eclipse.core.expressions
Product:	[Eclipse Project] Platform	Reporter:	Lars Vogel <Lars.Vogel>
Component:	Runtime	Assignee:	Alex Blewitt <alex.blewitt>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	alex.blewitt, Lars.Vogel
Version:	4.14
Target Milestone:	4.17 M1
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/164299 https://git.eclipse.org/c/platform/eclipse.platform.runtime.git/commit/?id=4a073b0b4bb233e84bac8d06f598dcf7c203f890
Whiteboard:
Bug Depends on:
Bug Blocks:	563542

Description Lars Vogel

2020-05-25 04:36:52 EDT

The only necessary usage of the activator in org.eclipse.core.expressions seems to provide the plug-in which we can also do via a constant interface.

Comment 1 Lars Vogel

2020-05-25 04:37:18 EDT

Alex, are you interested in providing a patch here?

Comment 2 Alex Blewitt

2020-05-26 09:18:12 EDT

Sure

Comment 3 Eclipse Genie

2020-06-05 12:39:22 EDT

New Gerrit change created: https://git.eclipse.org/r/164299

Comment 4 Alex Blewitt

2020-06-05 12:42:14 EDT

The change here inlines that of bug 563987, but could be refactored to use that if an appropriate home is found for the functionality.

Comment 5 Eclipse Genie

2020-06-07 12:27:27 EDT

Gerrit change https://git.eclipse.org/r/164299 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.runtime.git/commit/?id=4a073b0b4bb233e84bac8d06f598dcf7c203f890

Comment 6 Lars Vogel

2020-06-07 12:27:35 EDT

Thanks you, Alex.

Comment 7 Lars Vogel

2020-06-07 12:28:00 EDT

Thank you, Alex (not Thanks...)