Bugzilla – Full Text Bug Listing
|
Description
Pierre-Yves Bigourdan
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/165779 (In reply to Eclipse Genie from comment #1) > New Gerrit change created: > https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/165779 This should fix the wrongly scaped handle images. On macOS it looks nice. Can somebody pls. test in the various themes on windows and linux? (In reply to Matthias Becker from comment #2) > (In reply to Eclipse Genie from comment #1) > > New Gerrit change created: > > https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/165779 > > This should fix the wrongly scaped handle images. On macOS it looks nice. > Can somebody pls. test in the various themes on windows and linux? Looks good on Linux as well. I suggest to merge for M1. New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/165805 (In reply to Eclipse Genie from comment #4) > New Gerrit change created: > https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/165805 This removed the frames around the trim bars. Can somebody look at this on windows and linux? (In reply to Matthias Becker from comment #5) > (In reply to Eclipse Genie from comment #4) > > New Gerrit change created: > > https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/165805 > > This removed the frames around the trim bars. Can somebody look at this on > windows and linux? I tried out the patch (one Linux) but couldn't tell exactly what the difference was with the patch applied and not applied. Could you help point out the differences? (Maybe with a before/after photo?) Created attachment 283504 [details] Handles on Windows (In reply to Eclipse Genie from comment #1) > New Gerrit change created: > https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/165779 Unfortunately, this does not seem to work on Windows. Probably related to the issues I've described in https://bugs.eclipse.org/bugs/show_bug.cgi?id=563079#c43 (In reply to Pierre-Yves B. from comment #7) > Created attachment 283504 [details] > Handles on Windows > > (In reply to Eclipse Genie from comment #1) > > New Gerrit change created: > > https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/165779 > > Unfortunately, this does not seem to work on Windows. Probably related to > the issues I've described in > https://bugs.eclipse.org/bugs/show_bug.cgi?id=563079#c43 Hi Pierre, I don't have a windows machine. Can you pls. dig into this an update the gerrit? I'm still confused as to why it's working on Unix systems. You indicated in https://bugs.eclipse.org/bugs/show_bug.cgi?id=563079#c44 that url(./winTSFrame.png) from the CSS is translated to file:/......./org.eclipse.ui.themes/images/./winTSFrame.png. What does that translation? It doesn't seem intuitive to me. Why do we still need the CSS parameters at all? If none are specified, the theme engine falls back to the images in org.eclipse.e4.ui.workbench.swt. If we're now using the same ones for all operating systems, there's little point in having the overrides. :) Created attachment 285705 [details] Debugger Screenshot (In reply to Pierre-Yves Bigourdan from comment #9) > I'm still confused as to why it's working on Unix systems. You indicated in > https://bugs.eclipse.org/bugs/show_bug.cgi?id=563079#c44 that > url(./winTSFrame.png) from the CSS is translated to > file:/......./org.eclipse.ui.themes/images/./winTSFrame.png. What does that > translation? It doesn't seem intuitive to me. > > Why do we still need the CSS parameters at all? If none are specified, the > theme engine falls back to the images in org.eclipse.e4.ui.workbench.swt. If > we're now using the same ones for all operating systems, there's little > point in having the overrides. :) Dear Perrre-Yves, the "translation" from "./winTSFrame.png" to the "file:/...." path happens in OSGIResourceLocator (see the attached screenshot). The path that is created on macOS is fine. I also checked with a co-worker on his windows machine. There that relative filename is "translated" to something like: "file:...plugins/org.eclipse.ui.themes_1.2.1300.v20210108-1832/images/./dragHandle.png" which also loads fine on his computer. Can you please debug at that location and tell me what the problem is on your side? (In reply to Pierre-Yves Bigourdan from comment #9) > I'm still confused as to why it's working on Unix systems. You indicated in > https://bugs.eclipse.org/bugs/show_bug.cgi?id=563079#c44 that > url(./winTSFrame.png) from the CSS is translated to > file:/......./org.eclipse.ui.themes/images/./winTSFrame.png. What does that > translation? It doesn't seem intuitive to me. > > Why do we still need the CSS parameters at all? If none are specified, the > theme engine falls back to the images in org.eclipse.e4.ui.workbench.swt. If > we're now using the same ones for all operating systems, there's little > point in having the overrides. :) I updated https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/165779 now. I removed the CSS parameters as the drag handle images anyway are identical now. As all themes are touched on all OSes we need good manual tests. Pls. test with: a) themeing disabled b) all available themes of your OS For a) and b) have collapsed trim stacks on left/right and bottom edge of the window. Also move the collapsed trim stacks around (e.g. from left to bottom edge or vise versa). The trim handle dots should be squared and look good on "normal" resolution screens and "high" resolution screens. I tested on macOS with theming disabled, light, dark, classic and system theme. All look good. Created attachment 285712 [details]
With my patch on dark theme
Created attachment 285713 [details]
With my patch on light theme
Created attachment 285747 [details]
With patch on Windows
(In reply to Matthias Becker from comment #10) > Can you please debug at that location and tell me what the problem is on > your side? Even if the final solution makes the problem go away by removing the CSS, yes, I can take a look in the coming days or weeks. :) (In reply to Pierre-Yves Bigourdan from comment #15) > (In reply to Matthias Becker from comment #10) > > Can you please debug at that location and tell me what the problem is on > > your side? > > Even if the final solution makes the problem go away by removing the CSS, > yes, I can take a look in the coming days or weeks. :) Yes. That would be great. I updated to the latest nightly version of the IDE, but that caused errors on the Platform UI code from patch set 3 as it dates back from July. Therefore I locally rebased that old patch set on the latest version of the Platform UI code base. Following that, I am no longer able to reproduce the behaviour that I screenshoted in https://bugs.eclipse.org/bugs/show_bug.cgi?id=563497#c7. Maybe something was fixed in the more recent version of the IDE, maybe something was fixed in the more recent version of the Platform UI code base. Hard to tell as it's been over 8 months of changes, and frankly I don't think there's much value in digging any further. I'll instead do a bit more testing on patch set 6 and report back. Created attachment 285832 [details]
Handles with patch set 6
With patch set 6, using Windows, the handles still don't look quite right, but only when rotated horizontally. The vertical ones look good.
In the attached screnshot, note how the horizontal handler has a larger space in between the two middle dots, and how it looks darker compared to its vertical counterpart.
Is this something you can reproduce?
(In reply to Pierre-Yves Bigourdan from comment #18) > Is this something you can reproduce? Yes. It seems that the icon is scaled on windows - on macOS it looks good. It also seems that this scaling is unrelated to this change. Can you confirm this? If yes I propose we merge this change and create a follow up for the scaling issue... Created attachment 285841 [details]
Dark Linux with patch
(In reply to Lars Vogel from comment #20) > Created attachment 285841 [details] > Dark Linux with patch Does it look better then without may patch? Created attachment 285842 [details]
Light Linux with patch
Looks better IMHO on Linux dark and light theme.
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/165779 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=878ede4d5379463e47124ef2e10facb497527d68 (In reply to Matthias Becker from comment #19) > (In reply to Pierre-Yves Bigourdan from comment #18) > > Is this something you can reproduce? > Yes. It seems that the icon is scaled on windows - on macOS it looks good. > It also seems that this scaling is unrelated to this change. Can you confirm > this? Yes, that was already the case, as I described over here: https://bugs.eclipse.org/bugs/show_bug.cgi?id=563079#c33 *** Bug 563277 has been marked as a duplicate of this bug. *** New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/178348 New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/178349 Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/178348 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=a0b3b60c1440b7e48d8bfb4f0698b4632158a71c Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/178349 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b585373207295d55344a5f6e87a75ef2458acb67 New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.images/+/179284 Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.images/+/179284 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=d73e6828d2be33c12e67ce1f4574393007fcd222 Created attachment 286104 [details]
Screenshot Windows
Looks good to me in Eclipse SDK
Version: 2021-06 (4.20)
Build id: I20210414-0330
OS: Windows 8, v.6.2, x86_64 / win32
Java version: 15.0.2
Note: The D&D color of a toolbar is wrong in the dark theme but that is a difference issue.
(In reply to Lars Vogel from comment #32) > Created attachment 286104 [details] > Screenshot Windows > > Looks good to me in Eclipse SDK > Version: 2021-06 (4.20) > Build id: I20210414-0330 > OS: Windows 8, v.6.2, x86_64 / win32 > Java version: 15.0.2 > > > Note: The D&D color of a toolbar is wrong in the dark theme but that is a > difference issue. What happen to your linux laptop? (In reply to Matthias Becker from comment #33) > What happen to your linux laptop? This week I use windows, next week I will be back to Linux. *** Bug 563083 has been marked as a duplicate of this bug. *** |