Bug 563403

Comment 1 Amit Mendapara 2020-05-20 10:22:55 EDT

Here I am attaching a modified "e4_default_gtk.css" that make eclipse look more consistent on Linux (gnome 3.36).

Comment 2 Amit Mendapara 2020-05-20 10:23:20 EDT

Created attachment 282959 [details]
e4_default_gtk.css

Comment 3 Amit Mendapara 2020-05-20 10:25:13 EDT

Created attachment 282960 [details]
before.png

Comment 4 Amit Mendapara 2020-05-20 10:25:42 EDT

Created attachment 282961 [details]
after.png

Comment 5 Andrew Obuchowicz 2020-05-20 10:27:22 EDT

Hey Amit, thank you for your contribution! :)

Eclipse IDE uses Gerrit for contributing - we don't send files through Bugzilla but rather through Gerrit patches, eg. https://git.eclipse.org/r/#/c/162675/

Comment 6 Amit Mendapara 2020-05-20 10:49:26 EDT

(In reply to Andrew Obuchowicz from comment #5)
> Hey Amit, thank you for your contribution! :)
> 
> Eclipse IDE uses Gerrit for contributing - we don't send files through
> Bugzilla but rather through Gerrit patches, eg.
> https://git.eclipse.org/r/#/c/162675/

Thanks Andrew,

Yes but that would be too much for me but I can try. Would you point me to some reference doc to learn more about contributing by submitting patches?

Comment 7 Lars Vogel 2020-05-20 10:54:27 EDT

(In reply to Amit from comment #6)
> (In reply to Andrew Obuchowicz from comment #5)
> > Hey Amit, thank you for your contribution! :)
> > 
> > Eclipse IDE uses Gerrit for contributing - we don't send files through
> > Bugzilla but rather through Gerrit patches, eg.
> > https://git.eclipse.org/r/#/c/162675/
> 
> Thanks Andrew,
> 
> Yes but that would be too much for me but I can try. Would you point me to
> some reference doc to learn more about contributing by submitting patches?

See https://www.vogella.com/tutorials/EclipsePlatformDevelopment/article.html#exericse-eclipse-user-creation-and-gerrit-server-configuration Setup usually takes 5 -10 mins

Comment 8 Amit Mendapara 2020-05-20 13:38:45 EDT

(In reply to Lars Vogel from comment #7)
> (In reply to Amit from comment #6)
> > (In reply to Andrew Obuchowicz from comment #5)
> > > Hey Amit, thank you for your contribution! :)
> > > 
> > > Eclipse IDE uses Gerrit for contributing - we don't send files through
> > > Bugzilla but rather through Gerrit patches, eg.
> > > https://git.eclipse.org/r/#/c/162675/
> > 
> > Thanks Andrew,
> > 
> > Yes but that would be too much for me but I can try. Would you point me to
> > some reference doc to learn more about contributing by submitting patches?
> 
> See
> https://www.vogella.com/tutorials/EclipsePlatformDevelopment/article.
> html#exericse-eclipse-user-creation-and-gerrit-server-configuration Setup
> usually takes 5 -10 mins

Thanks. I will try soon.

Comment 9 Eclipse Genie 2020-05-20 14:52:12 EDT

New Gerrit change created: https://git.eclipse.org/r/163343

Comment 10 Amit Mendapara 2020-05-20 14:54:07 EDT

Created attachment 282965 [details]
after-final.png

Comment 11 Amit Mendapara 2020-05-20 15:00:12 EDT

Thanks Lars, Andrew,

So, I submitted by first contribution. Hope it was fine.

Comment 12 Lars Vogel 2020-05-21 06:58:45 EDT

Thanks Amit. We are in the release freeze right now. Will review early 4.17

Comment 13 Eclipse Genie 2020-06-11 14:12:37 EDT

Gerrit change https://git.eclipse.org/r/163343 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=83b9d48313cf5a22ec884034b06db7a86ab86c4b

Comment 14 Lars Vogel 2020-06-11 14:39:35 EDT

Thanks, Amit. Could you create an entry for the N&N 4.17?

Comment 15 Amit Mendapara 2020-06-12 02:30:41 EDT

(In reply to Lars Vogel from comment #14)
> Thanks, Amit. Could you create an entry for the N&N 4.17?

Yes, sure I will check soon. Thanks.

Comment 16 Lars Vogel 2020-06-12 03:01:12 EDT

(In reply to Amit Mendapara from comment #15)
> (In reply to Lars Vogel from comment #14)
> > Thanks, Amit. Could you create an entry for the N&N 4.17?
> 
> Yes, sure I will check soon. Thanks.

See here for an example https://git.eclipse.org/r/#/c/164756/ and screenshots must be small (see instructions in the repo)

Comment 17 Eclipse Genie 2020-06-12 14:43:37 EDT

New Gerrit change created: https://git.eclipse.org/r/164813

Comment 18 Amit Mendapara 2020-06-12 14:47:25 EDT

(In reply to Lars Vogel from comment #16)
> (In reply to Amit Mendapara from comment #15)
> > (In reply to Lars Vogel from comment #14)
> > > Thanks, Amit. Could you create an entry for the N&N 4.17?
> > 
> > Yes, sure I will check soon. Thanks.
> 
> See here for an example https://git.eclipse.org/r/#/c/164756/ and
> screenshots must be small (see instructions in the repo)

I just created a news entry. However, I had to make a little wider screenshots to show the subtle differences between the old and new theme.

Let me know if that is acceptable.

Comment 19 Lars Vogel 2020-06-15 02:28:55 EDT

(In reply to Amit Mendapara from comment #18)

> I just created a news entry. However, I had to make a little wider
> screenshots to show the subtle differences between the old and new theme.
> 
> Let me know if that is acceptable.

No, that is why we have the instructions. :-) Please update the images to be no more than 800 pixels wide.

Comment 20 Amit Mendapara 2020-06-15 03:17:39 EDT

(In reply to Lars Vogel from comment #19)
> (In reply to Amit Mendapara from comment #18)
> 
> > I just created a news entry. However, I had to make a little wider
> > screenshots to show the subtle differences between the old and new theme.
> > 
> > Let me know if that is acceptable.
> 
> No, that is why we have the instructions. :-) Please update the images to be
> no more than 800 pixels wide.

Done!

Comment 21 Eclipse Genie 2020-06-22 05:32:08 EDT

Gerrit change https://git.eclipse.org/r/164813 was merged to [master].
Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=45ace4b72fb10757d156d80c4c9974568edc29e4

Comment 22 Lars Vogel 2020-06-22 05:32:26 EDT

(In reply to Amit Mendapara from comment #20)
> Done!

Thanks.