Bug 563269

Description Carsten Hammer 2020-05-17 12:28:48 EDT

If the variable name created for the loop element variable is already used and a postfix number has to be appended it starts with 2 instead of 1.

Look at the results of this failing test:

	@Test
	public void testNameDetectionChildrenChildAlreadyUsed() throws Exception {
		IPackageFragment pack1= fSourceFolder.createPackageFragment("test1", false, null);
		StringBuilder buf= new StringBuilder();
		buf.append("package test1;\n");
		buf.append("public class A {\n");
		buf.append("	public void foo() {\n");
		buf.append("		int[] children = {1,2,3,4};\n");
		buf.append("		for (int i = 0; i < children.length; i++){\n");
		buf.append("			int child=1+1;\n");
		buf.append("		}\n");
		buf.append("	}\n");
		buf.append("}\n");
		ICompilationUnit cu= pack1.createCompilationUnit("A.java", buf.toString(), false, null);

		List<IJavaCompletionProposal> proposals= fetchConvertingProposal(buf, cu);

		assertNotNull(fConvertLoopProposal);

		assertCorrectLabels(proposals);

		String preview1= getPreviewContent(fConvertLoopProposal);

		buf= new StringBuilder();
		buf.append("package test1;\n");
		buf.append("public class A {\n");
		buf.append("	public void foo() {\n");
		buf.append("		int[] children = {1,2,3,4};\n");
		buf.append("		for (int child1 : children) {\n");
		buf.append("			int child=1+1;\n");
		buf.append("		}\n");
		buf.append("	}\n");
		buf.append("}\n");
		String expected= buf.toString();
		assertEqualString(preview1, expected);
	}

The created code contains "for (int child2 : children) {" although "child1" is not used.
I am not sure if this is a bug or is intended to have a bigger difference to the already used variable.