Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 562626

Summary:	"Cannot read property 'Name' of undefined" creating embedded editor
Product:	[ECD] Orion	Reporter:	Andrew Niefer <aniefer>
Component:	Editor	Assignee:	libing wang <libingw>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	libingw
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows 10
Whiteboard:

Description Andrew Niefer

2020-04-29 13:33:22 EDT

Found in 20.0 and 22.0, the CodeEdit widget as outlined on the wiki
https://wiki.eclipse.org/Orion/How_Tos/Code_Edit

fails to load the editor due to undefined file metadata in the input manager

"TypeError: Cannot read property 'Name' of undefined
    at EditorView.updateViewOptions (https://localhost:9443/jazz/web/com.ibm.team.scm.web/orion/code_edit/built-codeEdit.js:49007:84)
    at Editor.textViewFactory [as _textViewFactory] (https://localhost:9443/jazz/web/com.ibm.team.scm.web/orion/code_edit/built-codeEdit.js:49163:24)
    at Editor.install (https://localhost:9443/jazz/web/com.ibm.team.scm.web/orion/code_edit/built-codeEdit.js:33811:26)
    at EditorView.create (https://localhost:9443/jazz/web/com.ibm.team.scm.web/orion/code_edit/built-codeEdit.js:49524:16)
    at EditorSetupHelper.createEditor (https://localhost:9443/jazz/web/com.ibm.team.scm.web/orion/code_edit/built-codeEdit.js:49683:20)
    at CodeEdit.<anonymous> (https://localhost:9443/jazz/web/com.ibm.team.scm.web/orion/code_edit/built-codeEdit.js:50403:26)
    at settleDeferred (https://localhost:9443/jazz/web/com.ibm.team.scm.web/orion/code_edit/built-codeEdit.js:7015:28)
    at notify (https://localhost:9443/jazz/web/com.ibm.team.scm.web/orion/code_edit/built-codeEdit.js:7089:18)
    at MutationObserver.run (https://localhost:9443/jazz/web/com.ibm.team.scm.web/orion/code_edit/built-codeEdit.js:6973:13)"

Comment 1 libing wang

2020-04-30 20:33:39 EDT

Fixed with https://github.com/eclipse/orion.client/commit/d8ade8dafb932ea7398e62081624a4a1b3432f78

Comment 2 libing wang

2020-04-30 20:33:58 EDT

Fixed with https://github.com/eclipse/orion.client/commit/d8ade8dafb932ea7398e62081624a4a1b3432f78

Comment 3 libing wang

2020-05-01 14:17:54 EDT

Fixed another bug: got broken if enduser's URL has hash value
https://github.com/eclipse/orion.client/commit/05afd3c81fc486748fbf16d370fd0749e3325376