Bugzilla – Full Text Bug Listing
| Summary: | [Win32] Tree arrows on dark background | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Lars Vogel <Lars.Vogel> | ||||||
| Component: | UI | Assignee: | Lars Vogel <Lars.Vogel> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | 3iceh9i, alexandr.miloslavskiy, Lars.Vogel, pyvesdev | ||||||
| Version: | 4.16 | ||||||||
| Target Milestone: | 4.16 M3 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows 10 | ||||||||
| See Also: |
https://bugs.eclipse.org/bugs/show_bug.cgi?id=534151 https://git.eclipse.org/r/161775 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=12f872a2b4012a2e899aaf771f73b94a23c2a655 |
||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | 444560 | ||||||||
| Bug Blocks: | 560385, 562672 | ||||||||
| Attachments: |
|
||||||||
|
Description
Lars Vogel
Created attachment 282623 [details]
Screenshot of native Tree with dark scrollbars
This is how arrows look like in my native snippet. They should look the same in SWT with dark scrollbars patch. Why not just use as is?
(In reply to Alexandr Miloslavskiy from comment #1) > Created attachment 282623 [details] > Screenshot of native Tree with dark scrollbars > > This is how arrows look like in my native snippet. They should look the same > in SWT with dark scrollbars patch. Why not just use as is? +1, I try that out. Thanks. I think our drawing was done before SWT had this ability. Created attachment 282625 [details]
IDE in dark theme
Arrows without styling in platform.ui
Alexandr, looks awesome. Is this call handled by the OS.setTheme (isDark); call? If yes, I plan to deactivate / retire our custom drawing in platform ui for the dark theme. New Gerrit change created: https://git.eclipse.org/r/161775 Yes, the new arrows are a side benefit of `OS.setTheme(true)`. While we mostly use it for dark scrollbars, what it really does is selecting OS dark theme. The OS dark theme is not very complete at the moment, but already contains a few custom things for controls such as Tree and Table. Please remember that this is only available on Win10 (since version 1809 afair). (In reply to Alexandr Miloslavskiy from comment #6) > Yes, the new arrows are a side benefit of `OS.setTheme(true)`. While we > mostly use it for dark scrollbars, what it really does is selecting OS dark > theme. The OS dark theme is not very complete at the moment, but already > contains a few custom things for controls such as Tree and Table. Cool. Thanks for the info. > Please remember that this is only available on Win10 (since version 1809 afair). AFAIK Eclipse IDE does not support any other windows version than Win10, so this should be fine. Thanks again! (In reply to Lars Vogel from comment #0) > Is it possible to set the arrow colors for SWT trees? Currently we draw on > top of them in platform UI via our theming but it would be great if we can > avoid this, as this does not always work well. See Bug 534151. Another example of this not working properly: Bug 543962. *** Bug 543962 has been marked as a duplicate of this bug. *** *** Bug 534151 has been marked as a duplicate of this bug. *** Thanks Alexandr for the tip! Gerrit change https://git.eclipse.org/r/161775 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=12f872a2b4012a2e899aaf771f73b94a23c2a655 |