Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 562234

Summary:	Improve native callback logging for debugging purposes
Product:	[Eclipse Project] Platform	Reporter:	Alexandr Miloslavskiy <alexandr.miloslavskiy>
Component:	SWT	Assignee:	Alexandr Miloslavskiy <alexandr.miloslavskiy>
Status:	RESOLVED FIXED	QA Contact:	Alexandr Miloslavskiy <alexandr.miloslavskiy>
Severity:	normal
Priority:	P3	CC:	alexandr.miloslavskiy, loskutov
Version:	4.15
Target Milestone:	4.16 M3
Hardware:	PC
OS:	All
See Also:	https://git.eclipse.org/r/161102 https://bugs.eclipse.org/bugs/show_bug.cgi?id=562233 https://bugs.eclipse.org/bugs/show_bug.cgi?id=395381 https://bugs.eclipse.org/bugs/show_bug.cgi?id=562408 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=6ea564799a0ab24cce1db9b46541acaff0727774
Whiteboard:

Description Alexandr Miloslavskiy

2020-04-16 15:18:03 EDT

I have developed this code during investigation of Bug 562233 and Bug 395381.

I will provide patches soon.

Comment 1 Eclipse Genie

2020-04-16 15:51:56 EDT

New Gerrit change created: https://git.eclipse.org/r/161102

Comment 2 Eclipse Genie

2020-05-07 13:18:08 EDT

Gerrit change https://git.eclipse.org/r/161102 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=6ea564799a0ab24cce1db9b46541acaff0727774

Comment 3 Alexandr Miloslavskiy

2020-05-07 14:02:21 EDT

@Andrey Loskutov I never merged patches myself before, so I imagine I did something wrong? Can you please explain the change to 4.16 M3 ?

Also, are you willing to do code reviews while Alexander Kurtakov is away? Previously Eric Williams did code reviews for me, but now he left :(

Comment 4 Andrey Loskutov

2020-05-09 12:42:21 EDT

(In reply to Alexandr Miloslavskiy from comment #3)
> @Andrey Loskutov I never merged patches myself before, so I imagine I did
> something wrong? Can you please explain the change to 4.16 M3 ?

because we aren't in RC2 yet :-) Next milestone is M3.

> Also, are you willing to do code reviews while Alexander Kurtakov is away?
> Previously Eric Williams did code reviews for me, but now he left :(

Sure, if this is interesting for me :-) (no Mac/Windows or C/C++ related changes please, I work mostly on Linux/Java).