Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 562200

Summary: Move .MTrimmedWindow.topLevel is shared file
Product: [Eclipse Project] Platform Reporter: Lars Vogel <Lars.Vogel>
Component: UIAssignee: Philippe Dul <philippe.dul>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Lars.Vogel, philippe.dul
Version: 4.14   
Target Milestone: 4.16 M3   
Hardware: PC   
OS: Linux   
See Also: https://git.eclipse.org/r/161047
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=bf1ebeb566f6a09cd9385234c888c9f7ec893540
Whiteboard:
Bug Depends on:    
Bug Blocks: 562201    

Description Lars Vogel CLA 2020-04-16 04:48:34 EDT
Currently all CSS define this for all OSs I suggest to move it into the global dark and light theme.

.MTrimmedWindow.topLevel {
	margin-top: 0px;
	margin-bottom: 0px;
	margin-left: 1px;
	margin-right: 1px;
}
Comment 1 Lars Vogel CLA 2020-04-16 04:50:42 EDT
Philippe, what do you think? Could you take this bug?
Comment 2 Philippe Dul CLA 2020-04-16 06:18:01 EDT
I will look for it.

Splitting light theme into separate files like dark theme is a larger subject though :)
Comment 3 Eclipse Genie CLA 2020-04-16 06:18:23 EDT
New Gerrit change created: https://git.eclipse.org/r/161047
Comment 4 Lars Vogel CLA 2020-04-16 06:22:03 EDT
(In reply to Philippe Dul from comment #2)
> I will look for it.
> 
> Splitting light theme into separate files like dark theme is a larger
> subject though :)

Good point. Lets handle that via https://bugs.eclipse.org/bugs/show_bug.cgi?id=562206
Comment 6 Lars Vogel CLA 2020-04-17 04:03:42 EDT
Thanks Philippe