Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 561481

Summary:	Improve text for non-blocking preference of JDT
Product:	[Eclipse Project] JDT	Reporter:	Lars Vogel <Lars.Vogel>
Component:	UI	Assignee:	Lars Vogel <Lars.Vogel>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Lars.Vogel, mistria, noopur_gupta
Version:	4.14
Target Milestone:	4.16 M1
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/160026 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=c1853a088a40b98204bfa78ee3202eddf4928d51
Whiteboard:
Bug Depends on:
Bug Blocks:	558893

Description Lars Vogel

2020-03-26 06:37:51 EDT

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=558893#c4

Quote: 

We could also improve the preference text if required.

"Do not block UI thread while computing completion proposals... " sounds more technical.

Something like "Enable responsive completion (does not affect open editors)" or better wording can be used. The technical details for the preference are available in the F1 help.

Comment 1 Lars Vogel

2020-03-26 06:39:46 EDT

Noopur, what about? 

"Enable non-blocking completion", the (does not affect open editors) feels like too much information and should be part of the techical details.

Comment 2 Eclipse Genie

2020-03-26 06:51:38 EDT

New Gerrit change created: https://git.eclipse.org/r/160026

Comment 3 Noopur Gupta

2020-03-26 06:55:20 EDT

(In reply to Lars Vogel from comment #1)
> Noopur, what about? 
> 
> "Enable non-blocking completion", 
This is also fine.

> the (does not affect open editors) feels
> like too much information and should be part of the techical details.
It will be good to have it in the preference text to inform the user directly. Such text is also present at other locations in preferences e.g. Java > Editor > Hovers.

Comment 4 Lars Vogel

2020-03-26 06:58:13 EDT

(In reply to Noopur Gupta from comment #3)
> (In reply to Lars Vogel from comment #1)
> > Noopur, what about? 
> > 
> > "Enable non-blocking completion", 
> This is also fine.
> 
> > the (does not affect open editors) feels
> > like too much information and should be part of the techical details.
> It will be good to have it in the preference text to inform the user
> directly. Such text is also present at other locations in preferences e.g.
> Java > Editor > Hovers.

Ok, Gerrit adjusted.

Comment 5 Eclipse Genie

2020-03-26 11:57:57 EDT

Gerrit change https://git.eclipse.org/r/160026 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=c1853a088a40b98204bfa78ee3202eddf4928d51

Comment 6 Noopur Gupta

2020-03-26 11:58:33 EDT

Thanks, Lars.