Bugzilla – Full Text Bug Listing
| Summary: | Call wrong UI String for quick access label/header | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Jin Shi <shijinsj> | ||||||
| Component: | Debug | Assignee: | Noopur Gupta <noopur_gupta> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | daniel_megert, noopur_gupta, sarika.sinha | ||||||
| Version: | 4.15 | Flags: | sarika.sinha:
review+
|
||||||
| Target Milestone: | 4.15+ | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| See Also: |
https://git.eclipse.org/r/160030 https://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=4f984bac9597c5b0e8422a9923e971b0e502261f https://git.eclipse.org/r/160165 https://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=5c96c5ce9fab3ebc19cfd7574d75ed3c67f9da9d |
||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | 545544 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
Created attachment 282223 [details]
wrong string used for "Debug" which used as Header
A little more explanation such as "Run" "Run" menu and "Run" quick access label are both header, should use the same segment Eclipse 10621 10620 is for action and used at other context Or you can creating separated segments for those quick access labels if you would not like to reuse existing segments,like Eclipse59749,Properties Analyzer,eclipse\plugins\org.eclipse.text.quicksearch\plugin.properties,quickAccess.category.label,File content -------------------------------------------------------------- Eclipse10620,Properties Analyzer,eclipse\plugins\org.eclipse.debug.ui\plugin.properties,RunDropDownAction.label,Run Eclipse10621,Properties Analyzer,eclipse\plugins\org.eclipse.debug.ui\plugin.properties,RunMenu.label,&Run Eclipse10561,Properties Analyzer,eclipse\plugins\org.eclipse.debug.ui\plugin.properties,DebugDropDownAction.label,Debug Eclipse10568,Properties Analyzer,eclipse\plugins\org.eclipse.debug.ui\plugin.properties,DebugPerspective.name,Debug It needs more clarity as I could not understand the issue here. (In reply to Noopur Gupta from comment #4) > It needs more clarity as I could not understand the issue here. Please use this segment "RunMenu.label" in eclipse\plugins\org.eclipse.debug.ui\plugin.properties for word "Run" in quick access panel, rather than "RunDropDownAction.label", or you can create a new segment if you'd like. Also, please use "DebugPerspective.name" in eclipse\plugins\org.eclipse.debug.ui\plugin.properties for the word "Debug" in quick access panel, rather than "DebugDropDownAction.label", or you can create a new segment if you'd like The reason is "In Polish titles/headers have different translation than buttons". "RunDropDownAction.label" and "DebugDropDownAction.label" are for action buttons "RunDropDownAction.label" and "DebugPerspective.name" are for titles/headers So please use the latter ones, what showed in quick access panel look like header/titles. sorry for the bad copy&paste "RunDropDownAction.label" and "DebugDropDownAction.label" are for action buttons "RunMenu.label" and "DebugPerspective.name" are for titles/headers (In reply to Jin Shi from comment #5) > Please use this segment "RunMenu.label" in > eclipse\plugins\org.eclipse.debug.ui\plugin.properties for word "Run" in > quick access panel, rather than "RunDropDownAction.label", or you can create > a new segment if you'd like. > > Also, please use "DebugPerspective.name" in > eclipse\plugins\org.eclipse.debug.ui\plugin.properties for the word "Debug" > in quick access panel, rather than "DebugDropDownAction.label", or you can > create a new segment if you'd like Thanks, this makes it clear. Moving to Platform Debug. @Jin: do you think you could submit a Gerrit patch that fixes it? See https://wiki.eclipse.org/Gerrit and feel free to ask for more assistance if necessary. I will provide a patch. (In reply to Mickael Istria from comment #8) > @Jin: do you think you could submit a Gerrit patch that fixes it? See > https://wiki.eclipse.org/Gerrit and feel free to ask for more assistance if > necessary. I'd like to. Thanks for the wiki page. I will take a look and try to submit a Gerrit patch for future bugs. Noopur Gupta already said he would provide a patch for this one. New Gerrit change created: https://git.eclipse.org/r/160030 Gerrit change https://git.eclipse.org/r/160030 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=4f984bac9597c5b0e8422a9923e971b0e502261f To be backported to R4_15_maintenance. New Gerrit change created: https://git.eclipse.org/r/160165 Gerrit change https://git.eclipse.org/r/160165 was merged to [R4_15_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=5c96c5ce9fab3ebc19cfd7574d75ed3c67f9da9d |
Created attachment 282222 [details] wrong string used for "Run" which used as Header In Polish titles/headers have different translation than buttons. At place where showed Eclipse 10620, it should use Eclipse 10621 At place where show Eclipse 10561, it should use Eclipse 10568