Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 561137

Summary:	Change jdt.ui.tests ant script to run leaktestsuite based on javaversion
Product:	[Eclipse Project] JDT	Reporter:	Kalyan Prasad Tatavarthi <kalyan_prasad>
Component:	UI	Assignee:	Kalyan Prasad Tatavarthi <kalyan_prasad>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	sarika.sinha
Version:	4.15
Target Milestone:	4.15 M1
Hardware:	PC
OS:	All
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=561136 https://git.eclipse.org/r/159705 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=ed03fd5c525bc78bf83af0f7bcf628d64a9cd267 https://bugs.eclipse.org/bugs/show_bug.cgi?id=565411
Whiteboard:

Description Kalyan Prasad Tatavarthi

2020-03-16 03:00:42 EDT

Comment 1 Kalyan Prasad Tatavarthi

2020-03-16 03:05:51 EDT

For every Java release, to run LeakTestSuite we make a change in org.eclipse.jdt.ui.tests test.xml file by adding the new java version.
using the below code for conditional check
 <matches pattern="^(9|10|11|12|13|14)$" string="${ant.java.version}" />

Since Ant 1.10.2 we can use the below condition to do the same check.

<javaversion atleast="9"/>

This will help not making file changes for every new java release.

Comment 2 Kalyan Prasad Tatavarthi

2020-03-16 03:11:30 EDT

(In reply to Kalyan Prasad Tatavarthi from comment #1)
> For every Java release, to run LeakTestSuite we make a change in
> org.eclipse.jdt.ui.tests test.xml file by adding the new java version.
> using the below code for conditional check
>  <matches pattern="^(9|10|11|12|13|14)$" string="${ant.java.version}" />
> 
> Since Ant 1.10.2 we can use the below condition to do the same check.
> 
> <javaversion atleast="9"/>
> 
> This will help not making file changes for every new java release.

Current infrastructure uses Ant version 1.10.1

Once we move to the new infrastructure which used 1.10.5 I will make the change.

Comment 3 Eclipse Genie

2020-03-19 06:50:45 EDT

New Gerrit change created: https://git.eclipse.org/r/159705

Comment 4 Eclipse Genie

2020-03-19 07:31:27 EDT

Gerrit change https://git.eclipse.org/r/159705 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=ed03fd5c525bc78bf83af0f7bcf628d64a9cd267

Comment 5 Kalyan Prasad Tatavarthi

2020-04-16 11:11:58 EDT

*** Bug 562149 has been marked as a duplicate of this bug. ***