Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 561084

Summary:	DOT Editor - Add new project wizard / new file wizard based on Xtext
Product:	[Tools] GEF	Reporter:	Tamas Miklossy <miklossy>
Component:	GEF DOT	Assignee:	Zoey Gerrit Prigge <eclipse>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	unspecified
Target Milestone:	5.3.0 (2019-12) M2
Hardware:	PC
OS:	Windows 10
Whiteboard:

Description Tamas Miklossy

2020-03-13 02:34:17 EDT

The Xtext framework (2.14.0 and above) supports the definition of new project / new file wizard. This support should also be added to the GEF DOT Editor as well, since it is based on Xtext 2.17.0.

See also the following (german) blog posts about this topic:
- https://blogs.itemis.com/de/new-project-wizard-einfach-mit-xtext-2-14-generieren
- https://blogs.itemis.com/de/new-file-wizard-einfach-mit-xtext-2.14-generieren

Hint: This support has already been added to the Xtext Statemachine (fowlerdsl) example, see

https://github.com/eclipse/xtext-eclipse/commit/92a6062e83cfd2a45d44b9dafa66fb82d185fa39#diff-adcd129ff14f4e0bbe74cd099578cf68

Comment 1 Zoey Gerrit Prigge

2020-03-27 09:30:44 EDT

I pushed the following changes to the master branch.

[561084] Dot File and Project Wizards 
-set up file/project wizard creation in GenerateDot.mwe2
-implement DotFileTemplateProvider with an elaborate dot file template
-implement DotProjectTemplateProvider
-check in generated Messages.java and messages.properties
-check in generated icons
-include required plugins in dot.ui MANIFEST.MF and register wizards in
plugin.xml
-include xtend-gen in dot.ui build.properties and .classpath

Signed-off-by: Zoey Prigge <zprigge@itemis.com>
https://bugs.eclipse.org/bugs/show_bug.cgi?id=561084

Tamas, please have a look at the changes and comment, if you think the wizards are adequate.

Furthermore, I thought if we should change the icons used and perhaps change the project type such that we can set the necessary settings (autogeneration of graphviz rendering, graphviz engine, etc.) in the project creation dialogue.

Comment 2 Tamas Miklossy

2020-03-27 15:32:18 EDT

Nice work, Zoey!

I did some minor improvements of the GEF DOT new project/new file wizard:

- Removing Java nature/Java builder from the new GEF DOT project.
- Add .api_filters to the org.eclipse.gef.dot.ui plugin to exclude the
public methods belonging to the GEF DOT Xtext-based wizard.
- Renaming labels on the wizard GUI.
- Improve validation failure messages.
- Removing empty lines from the messages.properties file.

I think this issue can be marked resolved/fixed once target 2020-06 can be set.

Comment 3 Tamas Miklossy

2020-05-07 01:47:10 EDT

Fixed in 5.3.0 (2020-06)